Mbed Crypto Tests #8754

itayzafrir · 2018-11-15T15:15:16Z

Description

Add mbed-crypto basic functionality tests to mbed-os/TESTS/mbed-crypto/sanity directory.

This PR depends on the PR for the upcoming mbedtls release for mbed-os version 5.11.

Note this PR cannot be compiled or tested until mbedtls has been merged into mbed-os.

Pull request type

[ ] Fix
[ ] Refactor
[ ] Target update
[ ] Functionality change
[ ] Docs update
[x] Test update
[ ] Breaking change

Patater

OK

0xc0170

Fix the license

0xc0170 · 2018-11-15T16:54:51Z

TESTS/mbed-crypto/sanity/main.cpp

@@ -0,0 +1,301 @@
+#include <stdio.h>


add license header please (with SPDX identifier)

License added.

@0xc0170 , a license was added so I moved this PR to CI, please check that the license is ok with you.

NirSonnenschein · 2018-11-18T13:25:52Z

CI can't run on this as is, waiting for preceding PR (mbedTLS PR)

NirSonnenschein · 2018-11-25T19:08:45Z

@itayzafrir @avolinski : this cant run to due to a build issue:
[Error] crypto.h@3473,0: #5: cannot open source input file "crypto_struct.h": No such file or directory
probably needs to be adjusted to the changes in master.

0xc0170 · 2018-11-26T10:44:46Z

We would like to rerun CI for this PR, look at the failures

bulislaw · 2018-11-26T14:48:52Z

All the PRs need to be engineering ready (marked as "needs: CI") by the end of the day (Austin time). Otherwise it won't make 5.11 and will need to come in the next release (5.12 for features, 5.11.1 for fixes and new platforms).

cmonr · 2018-11-26T16:37:13Z

@itayzafrir Fyi, this still needs work.

However, since this is just test additions, at worst, this could be mobed to 5.11.1

Add tests setup code and random bytes generator test.

* Add support for entropy injection * Move psa_crypto_init & mbedtls_psa_crypto_free to setup & teardown handlers * Skip test_crypto_asymmetric_encrypt_decrypt if RSA generation is not supported

0xc0170 · 2018-11-28T11:03:20Z

@itayzafrir Is this still in progress (should it be needs: work) or ready for CI?

itayzafrir · 2018-11-28T11:05:52Z

Hi @0xc0170, some work was done over the past couple of days so I believe this is ready for CI.

0xc0170 · 2018-11-28T11:23:44Z

@Patater Still happy with the latest updates? I'll set this as needs: CI (might take a day to get in CI as there are still 5.11rc PR in the CI )

cmonr · 2018-11-29T16:36:13Z

CI started.

mbed-ci · 2018-11-29T20:01:40Z

Test run: SUCCESS

Summary: 3 of 3 test jobs passed
Build number : 3
Build artifacts
Build logs

cmonr · 2018-11-30T05:15:13Z

Looks like this PR had some build issues with one of the exporters. Follow this link to access the log failures: http://mbed-os-ci.s3-website-eu-west-1.amazonaws.com/?prefix=jenkins-ci/builds/exporter/8754/3/uvision5/FAIL/

One of the build failures:

...
compiling main.cpp...
compiling WisunInterface.cpp...
mbed-os\features\nanostack\nanostack-interface\Nanostack.h(278): warning:  #1300-D: call_in inherits implicit virtual
mbed-os\features\nanostack\mbed-mesh-api\source\WisunInterface.cpp: 1 warning, 0 errors
linking...
C:\Users\ADMINI~1\AppData\Local\Temp\p5a8-2(39): warning:  #47-D: incompatible redefinition of macro "MBED_RAM_SIZE" 
  #define MBED_RAM_SIZE               0x50000
C:\Users\ADMINI~1\AppData\Local\Temp\p5a8-2: 1 warning, 0 errors
.\.link_script.sct(45): error: L6236E: No section matches selector - no section to be FIRST/LAST.
Not enough information to list image symbols.
Not enough information to list load addresses in the image map.
Finished: 2 information, 0 warning and 1 error messages.
".\BUILD\mbed-os-example-blinky.axf" - 1 Error(s), 97 Warning(s).
Target not created.

Patater · 2018-11-30T10:19:42Z

@cmonr That failure looks entirely unrelated to the contents of this PR, as this PR does not touch mbed-os\features\nanostack\mbed-mesh-api\source\WisunInterface.cpp, the source of the error. MBED_RAM_SIZE is also not a string contained in the contents of this PR. Any ideas why this is showing up now and didn't on other previous PRs?

0xc0170 · 2018-11-30T10:26:18Z

That is correct, reported internally MBEDOSTEST-353, this is uvision5 CI issue

0xc0170 · 2018-11-30T11:38:02Z

Exporters restarted

NirSonnenschein added needs: review needs: preceding PR labels Nov 15, 2018

NirSonnenschein requested review from Patater and a team November 15, 2018 15:18

itayzafrir mentioned this pull request Nov 15, 2018

Mbed Crypto Tests itayzafrir/mbed-os#1

Closed

Patater approved these changes Nov 15, 2018

View reviewed changes

0xc0170 requested changes Nov 15, 2018

View reviewed changes

NirSonnenschein approved these changes Nov 18, 2018

View reviewed changes

NirSonnenschein added needs: CI risk: G and removed needs: review labels Nov 18, 2018

NirSonnenschein added the release-version: 5.11.0-rc1 label Nov 18, 2018

0xc0170 approved these changes Nov 19, 2018

View reviewed changes

NirSonnenschein added needs: work and removed needs: CI needs: preceding PR labels Nov 25, 2018

0xc0170 added risk: A and removed risk: G labels Nov 26, 2018

cmonr added release-version: 5.11.1 and removed risk: A release-version: 5.11.0-rc1 labels Nov 26, 2018

itayzafrir added 4 commits November 26, 2018 19:23

Introduce mbed-crypto tests

f81bb47

Add tests setup code and random bytes generator test.

Add mbed-crypto asymmetric encrypt decrypt test

118f353

Add mbed-crypto hash verify test

29bcb2e

Add mbed-crypto symmetric cipher encrypt decrypt test

ff3a36a

itayzafrir added 3 commits November 26, 2018 19:23

Add mbed-crypto asymmetric sign verify test

680d983

Add mbed-crypto key derivation test

c3a8659

Add license

7fa969f

NirSonnenschein force-pushed the mbed-crypto-tests branch from 5cabefd to 84e8705 Compare November 26, 2018 20:33

NirSonnenschein added needs: CI and removed needs: work labels Nov 26, 2018

Oren Cohen and others added 2 commits November 27, 2018 11:54

Test modifications

3e88dcf

* Add support for entropy injection * Move psa_crypto_init & mbedtls_psa_crypto_free to setup & teardown handlers * Skip test_crypto_asymmetric_encrypt_decrypt if RSA generation is not supported

Skip Mbed Crypto tests when when Mbed Crypto is OFF

1431e21

itayzafrir force-pushed the mbed-crypto-tests branch from 84e8705 to 1431e21 Compare November 27, 2018 09:59

Patater approved these changes Nov 29, 2018

View reviewed changes

cmonr added needs: work and removed needs: CI labels Nov 30, 2018

0xc0170 added needs: CI and removed needs: work labels Nov 30, 2018

0xc0170 added ready for merge and removed needs: CI labels Nov 30, 2018

0xc0170 merged commit ba6b36c into ARMmbed:master Nov 30, 2018

0xc0170 removed the ready for merge label Nov 30, 2018

cmonr added release-version: 5.11.0-rc3 and removed release-version: 5.11.1 labels Dec 11, 2018

Mbed Crypto Tests #8754

Mbed Crypto Tests #8754

Uh oh!

Conversation

itayzafrir commented Nov 15, 2018

Description

Pull request type

Uh oh!

Patater left a comment

Choose a reason for hiding this comment

Uh oh!

0xc0170 left a comment

Choose a reason for hiding this comment

Uh oh!

0xc0170 Nov 15, 2018

Choose a reason for hiding this comment

Uh oh!

itayzafrir Nov 18, 2018

Choose a reason for hiding this comment

Uh oh!

NirSonnenschein Nov 18, 2018

Choose a reason for hiding this comment

Uh oh!

NirSonnenschein commented Nov 18, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

NirSonnenschein commented Nov 25, 2018

Uh oh!

0xc0170 commented Nov 26, 2018

Uh oh!

bulislaw commented Nov 26, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

cmonr commented Nov 26, 2018

Uh oh!

0xc0170 commented Nov 28, 2018

Uh oh!

itayzafrir commented Nov 28, 2018

Uh oh!

0xc0170 commented Nov 28, 2018

Uh oh!

cmonr commented Nov 29, 2018

Uh oh!

mbed-ci commented Nov 29, 2018

Test run: SUCCESS

Uh oh!

cmonr commented Nov 30, 2018

Uh oh!

Patater commented Nov 30, 2018

Uh oh!

0xc0170 commented Nov 30, 2018

Uh oh!

0xc0170 commented Nov 30, 2018

Uh oh!

Uh oh!

NirSonnenschein commented Nov 18, 2018 •

edited

Loading

bulislaw commented Nov 26, 2018 •

edited

Loading