Skip to content

Disable SecureStore if custom MBEDTLS config disables required features #8869

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

davidsaada
Copy link
Contributor

Description

SecureStore class depends on the MBED TLS AES CTR encryption and CMAC calculation features. These features are enabled by default by SecureStore itself. This PR disables SecureStore if the user overrides the MBED TLS configuration and excludes these features (otherwise we'll get a compilation error).

Resolves #8865

Pull request type

[x] Fix
[ ] Refactor
[ ] Target update
[ ] Functionality change
[ ] Docs update
[ ] Test update
[ ] Breaking change

@cmonr cmonr requested a review from a team November 26, 2018 16:51
Copy link
Contributor

@yossi2le yossi2le left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@davidsaada davidsaada closed this Dec 6, 2018
@davidsaada davidsaada deleted the david_securestore_mbedtls_config branch December 6, 2018 13:04
@davidsaada
Copy link
Contributor Author

Moved this fix to #8987.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants