-
Notifications
You must be signed in to change notification settings - Fork 3k
Update Ticker wrapper to handle early interrupts #8956
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Update the LowPowerTickerWrapper class to handle rather than ignore early low power ticker interrupts. This ensures that devices don't get stuck in sleep due to a ignored early low power ticker interrupt.
This PR will cause more frequent low power ticker rescheduling and removes code which prevents violating this part of the HAL specification: Lines 70 to 71 in f8e1116
The benefit this brings is greatly increased stability since early low power ticker interrupts won't cause a lockup, as is the case in #8906. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Change looks good to me, but @c1728p9 I'm wondering if this also needs input from Partners (ping @ashok-rao @MarceloSalazar @screamerbg) or @ARMmbed/mbed-os-hal |
Marking for 11.1 since this feels like it's a fix, but could also be seen as a breaking change, pushing it out to 12.0-rc1 |
@klaas019 Thanks for the context. Will keep at 11.1 for now. |
CI started |
Test run: SUCCESSSummary: 4 of 4 test jobs passed |
Description
Update the LowPowerTickerWrapper class to handle rather than ignore early low power ticker interrupts. This ensures that devices don't get stuck in sleep due to a ignored early low power ticker interrupt.
Pull request type