Move socket-stats-enable config to socket-stats-enabled #9067

kegilbert · 2018-12-12T00:15:32Z

Description

This conforms with the other stats config option names.

TODO:

Update Example
Update Docs

Pull request type

[ ] Fix
[X] Refactor
[ ] Target update
[ ] Functionality change
[ ] Docs update
[ ] Test update
[ ] Breaking change

deepikabhavnani · 2018-12-12T23:04:57Z

@kegilbert - Looks good to me, but I have a query: Documents get updated for patch version changes or minor as well?

If we leave it as _enable in document and merge this PR in master it will not match. I would not be much concerned about old feature as most of the times user get aware of the code and check it directly in master, but for new feature should we hold this consistency change for next minor?

cmonr · 2018-12-12T23:09:35Z

@ARMmbed/mbed-docs Question about when updates happen

iriark01 · 2018-12-13T06:00:33Z

We don't build master publicly; the public doxygen is always from an official release branch.
We do build master for the test documentation, and that will be updated almost as soon as you merge.

cmonr · 2018-12-14T01:24:45Z

I'm fine with this, but from what I can tell, this would need to be pushed out to 5.12. Please correct me if this is wrong.

deepikabhavnani · 2018-12-14T01:30:39Z

Yes 5.12

cmonr · 2018-12-21T03:53:35Z

@kegilbert I suspect that the example(s) would need to be updated before this could be tested?

kegilbert · 2018-12-25T09:56:05Z

Correct @cmonr

0xc0170 · 2019-01-16T12:26:43Z

@kegilbert What is the status here? Any upcoming updates here as this PR is still open

kegilbert · 2019-01-16T17:59:37Z

Apologies for the delay, I'll update the docs and examples for this.

kegilbert · 2019-01-16T19:35:03Z

Docs: ARMmbed/mbed-os-5-docs#923
Example: ARMmbed/mbed-os-example-socket-stats#8

deepikabhavnani

Good to go 👍

0xc0170 · 2019-01-18T11:37:32Z

CI started

mbed-ci · 2019-01-18T20:15:31Z

Test run: FAILED

Summary: 1 of 7 test jobs failed
Build number : 1
Build artifacts

Failed test jobs:

jenkins-ci/mbed-os-ci_build-ARM

alekla01 · 2019-01-18T20:55:44Z

restarted ci

mbed-ci · 2019-01-19T09:22:32Z

Test run: SUCCESS

Summary: 11 of 11 test jobs passed
Build number : 2
Build artifacts

bulislaw · 2019-02-26T15:19:06Z

This PR is at risk of missing 5.12 release as it's marked as "needs: work". Code freeze is coming! On Friday 1st. Please make necessary updates ASAP and make sure the reviewers are aligned for prompt code inspection.

cmonr · 2019-02-27T05:28:28Z

@kegilbert ?

cmonr · 2019-02-27T17:24:50Z

#9067 (comment)

0xc0170 · 2019-03-01T11:01:16Z

What's the status here? Two PRs are still opened.

deepikabhavnani · 2019-03-01T14:35:34Z

What's the status here? Two PRs are still opened

Other PR's can be merged after this is in. This is good to go to CI.

Query - Example PR is up - not in merged state. Should that be merged first for CI to start in this PR?
If I update the example first, other PR's in CI will fail for example.

cmonr · 2019-03-01T16:49:49Z

#9067 (comment)

The example needs to be updated first.

If this runs with the current example, the example build will fail because the config parameter changed.

deepikabhavnani · 2019-03-01T16:52:20Z

The example needs to be updated first

Example merged

cmonr · 2019-03-01T18:27:00Z

CI started

cmonr · 2019-03-01T18:27:37Z

#9906 (comment)

Now that the example has been updated, build will start to fail until this is merged into master.

CC @ARMmbed/mbed-os-maintainers

mbed-ci · 2019-03-01T19:14:41Z

Test run: FAILED

Summary: 3 of 9 test jobs failed
Build number : 3
Build artifacts

Failed test jobs:

jenkins-ci/mbed-os-ci_build-IAR8
jenkins-ci/mbed-os-ci_build-GCC_ARM
jenkins-ci/mbed-os-ci_build-ARMC5

deepikabhavnani · 2019-03-01T19:24:23Z

@kegilbert -

"./BUILD/K66F/IAR/.includes_980defce55bb8bfa1a450986b3159977.txt --preinclude=./BUILD/K66F/IAR/mbed_config.h --dependencies BUILD/K66F/IAR/mbed-os/features/netsocket/SocketStats.d -l BUILD/K66F/IAR/mbed-os/features/netsocket/SocketStats.s.txt -o BUILD/K66F/IAR/mbed-os/features/netsocket/SocketStats.o ./mbed-os/features/netsocket/SocketStats.cpp
[Error] SocketStats.cpp@28,35: [Pe135]: class "SocketStats" (declared at line 59 of "/builds/ws/mbed-os-ci_build-IAR8@10/mbed-os/features/netsocket/SocketStats.h") has no member "_mutex"
[Error] SocketStats.cpp@29,24: [Pe135]: class "SocketStats" (declared at line 59 of "/builds/ws/mbed-os-ci_build-IAR8@10/mbed-os/features/netsocket/SocketStats.h") has no member "_stats"
[Error] SocketStats.cpp@30,19: [Pe135]: class "SocketStats" (declared at line 59 of "

deepikabhavnani · 2019-03-01T19:25:50Z

Missed this one
https://github.com/ARMmbed/mbed-os/blob/c13052bd5d89936c8b7b7785f1a98e4b66e584f2/features/netsocket/SocketStats.h#L146

This conforms with the other stats config option names

cmonr · 2019-03-01T19:48:26Z

CI started

cmonr · 2019-03-01T19:54:42Z

CI started

mbed-ci · 2019-03-01T20:03:52Z

Test run: FAILED

Summary: 7 of 9 test jobs failed
Build number : 4
Build artifacts

Failed test jobs:

jenkins-ci/mbed-os-ci_build-ARMC6
jenkins-ci/mbed-os-ci_build-GCC_ARM
jenkins-ci/mbed-os-ci_build-ARMC5
jenkins-ci/mbed-os-ci_mbed2-build-ARMC5
jenkins-ci/mbed-os-ci_build-IAR8
jenkins-ci/mbed-os-ci_mbed2-build-GCC_ARM
jenkins-ci/mbed-os-ci_mbed2-build-IAR8

cmonr · 2019-03-01T20:04:45Z

Ignore #9067 (comment). This is from the last stopped job.

mbed-ci · 2019-03-01T22:19:03Z

Test run: SUCCESS

Summary: 13 of 13 test jobs passed
Build number : 5
Build artifacts

kegilbert requested a review from deepikabhavnani December 12, 2018 00:15

cmonr added the needs: review label Dec 12, 2018

cmonr approved these changes Dec 14, 2018

View reviewed changes

cmonr added the release-version: 5.12.0-rc1 label Dec 14, 2018

0xc0170 approved these changes Dec 14, 2018

View reviewed changes

cmonr added needs: preceding PR parked labels Dec 28, 2018

This was referenced Jan 16, 2019

Update nsapi.socket-stats-enable macro to new term ARMmbed/mbed-os-example-socket-stats#8

Merged

Update socket stats macro name ARMmbed/mbed-os-5-docs#923

Merged

cmonr removed the parked label Jan 17, 2019

deepikabhavnani approved these changes Jan 17, 2019

View reviewed changes

cmonr added needs: CI and removed needs: preceding PR needs: review labels Jan 17, 2019

0xc0170 added ready for merge and removed needs: CI labels Jan 21, 2019

cmonr added needs: CI and removed needs: work labels Mar 1, 2019

cmonr mentioned this pull request Mar 1, 2019

DOCS: fix doxygen not being generated for BLE classes #9906

Merged

Move socket-stats-enable to socket-stats-enabled.

8cef190

This conforms with the other stats config option names

kegilbert force-pushed the socket-stats-name-conform branch 2 times, most recently from 2d3fbcd to 16e0ca9 Compare March 1, 2019 19:48

Update recently added previous macro name uses in tests

194fa12

kegilbert force-pushed the socket-stats-name-conform branch from 16e0ca9 to 194fa12 Compare March 1, 2019 19:54

ghost added the PM_ACCEPTED label Mar 1, 2019

SenRamakri mentioned this pull request Mar 1, 2019

ARM Toolchain update to ARM Compiler 6.11(ARMC6) #9888

Merged

cmonr merged commit c9192b9 into ARMmbed:master Mar 1, 2019

cmonr removed the needs: CI label Mar 1, 2019

cmonr mentioned this pull request Mar 5, 2019

Feature watchdog #9840

Closed

Move socket-stats-enable config to socket-stats-enabled #9067

Move socket-stats-enable config to socket-stats-enabled #9067

Uh oh!

Conversation

kegilbert commented Dec 12, 2018 • edited by deepikabhavnani Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Pull request type

Uh oh!

deepikabhavnani commented Dec 12, 2018

Uh oh!

cmonr commented Dec 12, 2018

Uh oh!

iriark01 commented Dec 13, 2018

Uh oh!

cmonr commented Dec 14, 2018

Uh oh!

deepikabhavnani commented Dec 14, 2018

Uh oh!

cmonr commented Dec 21, 2018

Uh oh!

kegilbert commented Dec 25, 2018

Uh oh!

0xc0170 commented Jan 16, 2019

Uh oh!

kegilbert commented Jan 16, 2019

Uh oh!

kegilbert commented Jan 16, 2019

Uh oh!

deepikabhavnani left a comment

Choose a reason for hiding this comment

Uh oh!

0xc0170 commented Jan 18, 2019

Uh oh!

mbed-ci commented Jan 18, 2019

Test run: FAILED

Uh oh!

alekla01 commented Jan 18, 2019

Uh oh!

mbed-ci commented Jan 19, 2019

Test run: SUCCESS

Uh oh!

bulislaw commented Feb 26, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

cmonr commented Feb 27, 2019

Uh oh!

cmonr commented Feb 27, 2019

Uh oh!

0xc0170 commented Mar 1, 2019

Uh oh!

deepikabhavnani commented Mar 1, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

cmonr commented Mar 1, 2019

Uh oh!

deepikabhavnani commented Mar 1, 2019

Uh oh!

cmonr commented Mar 1, 2019

Uh oh!

cmonr commented Mar 1, 2019

Uh oh!

mbed-ci commented Mar 1, 2019

Test run: FAILED

Uh oh!

deepikabhavnani commented Mar 1, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

deepikabhavnani commented Mar 1, 2019

Uh oh!

cmonr commented Mar 1, 2019

Uh oh!

cmonr commented Mar 1, 2019

Uh oh!

mbed-ci commented Mar 1, 2019

Test run: FAILED

Uh oh!

cmonr commented Mar 1, 2019

Uh oh!

mbed-ci commented Mar 1, 2019

kegilbert commented Dec 12, 2018 •

edited by deepikabhavnani

Loading

bulislaw commented Feb 26, 2019 •

edited

Loading

deepikabhavnani commented Mar 1, 2019 •

edited

Loading

deepikabhavnani commented Mar 1, 2019 •

edited

Loading