Skip to content

mbed.h includes removed #9210

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Jan 4, 2019
Merged

mbed.h includes removed #9210

merged 7 commits into from
Jan 4, 2019

Conversation

AnttiKauppila
Copy link

@AnttiKauppila AnttiKauppila commented Dec 28, 2018 •
edited
Loading

Description

Removed internal includes of mbed.h from code and added missing headers.
Test, unittest, Target and unsupported folders were not touched.

Pull request type

[X] Fix
[ ] Refactor
[ ] Target update
[ ] Functionality change
[ ] Docs update
[ ] Test update
[ ] Breaking change

Reviewers

@AnttiKauppila
Copy link
Author

@dannybenor @donatieng @artokin @AriParkkila Please review your part of the changes.

@artokin
Copy link
Contributor

artokin commented Dec 28, 2018

Adding @SeppoTakalo to review nanostack (mbed-mesh-api/interface) related changes.

@ciarmcom ciarmcom requested review from a team December 28, 2018 14:00
@ciarmcom
Copy link
Member

@AnttiKauppila, thank you for your changes.
@ARMmbed/mbed-os-pan @ARMmbed/mbed-os-storage @ARMmbed/mbed-os-core @ARMmbed/mbed-os-mesh @ARMmbed/mbed-os-ipcore @ARMmbed/mbed-os-maintainers please review.

@AnttiKauppila
Copy link
Author

@OPpuolitaival When this gets merged in, your team can update CI to check that mbed.h is not included in upcoming PRs.

deepikabhavnani
deepikabhavnani reviewed Dec 28, 2018
View reviewed changes
Copy link

@deepikabhavnani deepikabhavnani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, except for small changes suggested

@cmonr cmonr requested a review from SeppoTakalo December 28, 2018 16:20
@AnttiKauppila
Copy link
Author

@deepikabhavnani Thanks for your feedback. Valid points but whole file seems to be a bit odd.
The whole file is behind:
#if defined(MBED_CONF_NANOSTACK_CONFIGURATION) && DEVICE_SPI && defined(MBED_CONF_RTOS_PRESENT)
So your comments should be already addressed?
Created a defect for this: https://jira.arm.com/browse/ONME-4103

@cmonr
Copy link
Contributor

cmonr commented Jan 3, 2019

CI started

@mbed-ci
Copy link

mbed-ci commented Jan 3, 2019

Test run: FAILED

Summary: 3 of 7 test jobs failed
Build number : 1
Build artifacts

Failed test jobs:

  • jenkins-ci/mbed-os-ci_build-GCC_ARM
  • jenkins-ci/mbed-os-ci_build-ARM
  • jenkins-ci/mbed-os-ci_build-IAR

@cmonr
Copy link
Contributor

cmonr commented Jan 3, 2019

Close!

@AnttiKauppila Please check the build errors with the NCS36510 and REALTEK_RTL8195AM targets.

@cmonr
Copy link
Contributor

cmonr commented Jan 3, 2019

CI started

@mbed-ci
Copy link

mbed-ci commented Jan 4, 2019

Test run: SUCCESS

Summary: 11 of 11 test jobs passed
Build number : 2
Build artifacts

@cmonr
Copy link
Contributor

cmonr commented Jan 4, 2019

One more OK from one of the following teams, and I think we'll be good to merge this:
@ARMmbed/mbed-os-mesh
@ARMmbed/mbed-os-pan
@ARMmbed/mbed-os-storage

@donatieng donatieng mentioned this pull request Jan 4, 2019
Merged
@donatieng
Copy link
Contributor

FYI AnttiKauppila#7 - this fixes compilation issues with BLE files impacted by this PR

@AnttiKauppila
Copy link
Author

Thanks @donatieng 👍

@0xc0170
Copy link
Contributor

0xc0170 commented Jan 4, 2019

CI started

@mbed-ci
Copy link

mbed-ci commented Jan 4, 2019

Test run: SUCCESS

Summary: 11 of 11 test jobs passed
Build number : 3
Build artifacts

@cmonr cmonr merged commit 54f7591 into ARMmbed:master Jan 4, 2019
@AnttiKauppila AnttiKauppila deleted the mbed_h_fix branch January 5, 2019 14:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bulislaw bulislaw bulislaw approved these changes

@0xc0170 0xc0170 0xc0170 approved these changes

@SeppoTakalo SeppoTakalo SeppoTakalo approved these changes

@deepikabhavnani deepikabhavnani deepikabhavnani approved these changes

Assignees
No one assigned
Labels
release-version: 5.11.2
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
10 participants
@AnttiKauppila @artokin @ciarmcom @cmonr @mbed-ci @donatieng @0xc0170 @bulislaw @SeppoTakalo @deepikabhavnani