Skip to content

mbed_boot_arm_std.c: remove redundant compiler check #9352

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jan 15, 2019
Merged

mbed_boot_arm_std.c: remove redundant compiler check #9352

merged 2 commits into from
Jan 15, 2019

Conversation

mprse
Copy link
Contributor

@mprse mprse commented Jan 11, 2019

Description

Fix for ARMC6 compiler.

Pull request type

[X] Fix
[ ] Refactor
[ ] Target update
[ ] Functionality change
[ ] Docs update
[ ] Test update
[ ] Breaking change

@0xc0170
Copy link
Contributor

0xc0170 commented Jan 11, 2019

I could reproduce this error locally: "rtos\TARGET_CORTEX\TOOLCHAIN_ARM_STD\mbed_boot_arm_std.c:64:26: error: use of undeclared identifier 'ISR_STACK_START'" using ARMC6

Once the patch applied, I was able to build the test.

K64F::ARMC6::TESTS-MBEDMICRO-RTOS-MBED-MALLOC

@0xc0170
Copy link
Contributor

0xc0170 commented Jan 11, 2019

cc @teetak01

@0xc0170
Copy link
Contributor

0xc0170 commented Jan 11, 2019

The fix goes for 5.12 as it's dependent on the changes for 5.12

@0xc0170
Copy link
Contributor

0xc0170 commented Jan 11, 2019

Thinking about this more. As we noticed this failure for ARMC6. It should have been caught in CI for v8, shouldn't it ?

@0xc0170
Copy link
Contributor

0xc0170 commented Jan 11, 2019

I've checked one nuvoton v8 target, it defines ISR_STACK_SIZE thus was not executing failing code as in this fix. Thus was not discovered in the CI (ARMC6 was built there).

@0xc0170
Copy link
Contributor

0xc0170 commented Jan 11, 2019

CI started

@0xc0170
Copy link
Contributor

0xc0170 commented Jan 11, 2019

Aborted, needs to wait for #9350

mprse added 2 commits January 11, 2019 12:59
@mprse
mbed_boot_arm_std.c: remove redundant compiler check
bfcdb7d 
Check is not needed since this file is exclusive for ARM compiler.
It causes problems on ARMC6.
@mprse
mbed_boot_gcc_arm.c: remove redundant compiler check
8cc4234
@mprse
Copy link
Contributor Author

mprse commented Jan 11, 2019

Added also similar fix for GCC.

@0xc0170
Copy link
Contributor

0xc0170 commented Jan 11, 2019

CI started

@mbed-ci
Copy link

mbed-ci commented Jan 11, 2019

Test run: SUCCESS

Summary: 11 of 11 test jobs passed
Build number : 2
Build artifacts

@NirSonnenschein
Copy link
Contributor

@0xc0170 this passed CI, does it need another review or can it be moved to "ready"

@0xc0170 0xc0170 merged commit aff2bee into ARMmbed:master Jan 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0xc0170 0xc0170 0xc0170 approved these changes

Assignees
No one assigned
Labels
release-version: 5.12.0-rc1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mprse @0xc0170 @mbed-ci @NirSonnenschein