Skip to content

ESP8266: calls MBED_ERROR if modem's watchdog reset gets triggered #9456

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 31, 2019
Merged

ESP8266: calls MBED_ERROR if modem's watchdog reset gets triggered #9456

merged 1 commit into from
Jan 31, 2019

Conversation

VeijoPesonen
Copy link
Contributor

@VeijoPesonen VeijoPesonen commented Jan 22, 2019 •
edited
Loading

Description

ESP8266: calls MBED_ERROR if modem's watchdog reset gets triggered. Addresses the issue #9425

Pull request type

[ ] Fix
[ ] Refactor
[ ] Target update
[X] Functionality change
[ ] Docs update
[ ] Test update
[ ] Breaking change

Reviewers

@SeppoTakalo
@kjbracey-arm
@michalpasztamobica

michalpasztamobica
michalpasztamobica approved these changes Jan 22, 2019
View reviewed changes
Copy link
Contributor

@michalpasztamobica michalpasztamobica left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I checked that there is also MBED_ERROR_CODE_TIMEOUT, but I guess you made a better choice. I personally don't understand the difference between the two and TIMEOUT isn't used anywhere, so let's stick with ETIME.

@ciarmcom
Copy link
Member

@VeijoPesonen, thank you for your changes.
@SeppoTakalo @kjbracey-arm @michalpasztamobica @ARMmbed/mbed-os-ipcore @ARMmbed/mbed-os-maintainers please review.

@VeijoPesonen VeijoPesonen mentioned this pull request Jan 24, 2019
Closed
@0xc0170
Copy link
Contributor

0xc0170 commented Jan 29, 2019

While we finalize reviews, CI started

@mbed-ci
Copy link

mbed-ci commented Jan 29, 2019

Test run: FAILED

Summary: 1 of 12 test jobs failed
Build number : 1
Build artifacts

Failed test jobs:

  • jenkins-ci/mbed-os-ci_greentea-test

@alekla01
Copy link
Contributor

jenkins-ci/greentea-test restarted

@cmonr
Copy link
Contributor

cmonr commented Jan 30, 2019

Waiting on either @kjbracey-arm or @michalpasztamobica to ok before merging.

@VeijoPesonen
Copy link
Contributor Author

@michalpasztamobica please re-review.

@cmonr cmonr merged commit b506b03 into ARMmbed:master Jan 31, 2019
@VeijoPesonen VeijoPesonen deleted the feature-esp8266_mbed_error_if_wdt branch September 6, 2019 10:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0xc0170 0xc0170 0xc0170 approved these changes

@kjbracey kjbracey Awaiting requested review from kjbracey

+2 more reviewers

@SeppoTakalo SeppoTakalo SeppoTakalo approved these changes

@michalpasztamobica michalpasztamobica michalpasztamobica approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
release-version: 5.12.0-rc1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@VeijoPesonen @ciarmcom @0xc0170 @mbed-ci @alekla01 @cmonr @SeppoTakalo @michalpasztamobica