Skip to content

Refactor storage components #9478

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jan 31, 2019
Merged

Refactor storage components #9478

merged 2 commits into from
Jan 31, 2019

Conversation

deepikabhavnani
Copy link

@deepikabhavnani deepikabhavnani commented Jan 23, 2019 •
edited
Loading

Description

  1. Move common util folder for tests inside TESTS directory
  2. Config folder not needed for json file

Pull request type

[X] Fix
[ ] Refactor
[ ] Target update
[ ] Functionality change
[ ] Docs update
[ ] Test update
[ ] Breaking change

Reviewers

@ciarmcom ciarmcom requested review from a team January 23, 2019 18:00
@ciarmcom
Copy link
Member

@deepikabhavnani, thank you for your changes.
@ARMmbed/mbed-os-storage @ARMmbed/mbed-os-maintainers please review.

davidsaada
davidsaada approved these changes Jan 23, 2019
View reviewed changes
Copy link
Contributor

@davidsaada davidsaada left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good and makes much sense. 👍

@deepikabhavnani
Copy link
Author

@ARMmbed/mbed-os-maintainers - Please review

deepikabhavnani added 2 commits January 30, 2019 16:51
Moved mbed_lib.json outside config folder
0d6bd27 
This is to have consistency across all storage components
Moved util (common test folder) inside the TESTS directory
2952735 
Util was common test folder, which was kept outside as we had
no mechanism to have common files for various tests in tools.
Now same can be achieved by having COMMON folder inside tests
directory
@deepikabhavnani
Copy link
Author

Rebased to resolve conflicts

@cmonr
Copy link
Contributor

cmonr commented Jan 31, 2019

CI started

@mbed-ci
Copy link

mbed-ci commented Jan 31, 2019

Test run: SUCCESS

Summary: 12 of 12 test jobs passed
Build number : 1
Build artifacts

@cmonr cmonr merged commit ffc52e6 into ARMmbed:master Jan 31, 2019
@deepikabhavnani deepikabhavnani deleted the refactor_sd branch January 31, 2019 22:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
2 more reviewers

@cmonr cmonr cmonr approved these changes

@davidsaada davidsaada davidsaada approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
release-version: 5.11.4
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@deepikabhavnani @ciarmcom @cmonr @mbed-ci @davidsaada @0xc0170