Bare metal mbed_lib updates #9628

orenc17 · 2019-02-06T11:37:03Z

Description

Create missing mbed_lib.json for the following libs:

kv-config
storage
direct-access-devicekey
filesystemstore
kv-global-api
kv-map
tdbstore
PSA

Relays on #9561

Pull request type

[ ] Fix
[ ] Refactor
[ ] Target update
[X] Functionality change
[ ] Docs update
[ ] Test update
[ ] Breaking change

Reviewers

@theotherjimmy @davidsaada @yossi2le

Release notes

Make the following modules comply with bare-metal:

kv-config
storage
direct-access-devicekey
filesystemstore
kv-global-api
kv-map
tdbstore
PSA-services

ciarmcom · 2019-02-06T12:01:00Z

@orenc17, thank you for your changes.
@theotherjimmy @yossi2le @davidsaada @ARMmbed/mbed-os-pan @ARMmbed/mbed-os-tools @ARMmbed/mbed-os-mesh @ARMmbed/mbed-os-ipcore @ARMmbed/mbed-os-maintainers @ARMmbed/mbed-os-storage please review.

jeromecoutant · 2019-02-06T12:46:44Z

features/storage/kvstore/conf/global/mbed_lib.json

+            "storage_type": "TDB_INTERNAL"
+        },
+        "NUCLEO_F411RE": {
+            "storage_type": "TDB_INTERNAL"


that's was in the original mbed_lib.json

@jeromecoutant Could you please move this comment to #9561?

theotherjimmy

Looks fine to me. Should I close the prior PR?

orenc17 · 2019-02-06T14:26:32Z

@theotherjimmy merge your PR first and then i'll rebase

SeppoTakalo · 2019-02-06T14:36:32Z

features/nanostack/mbed_lib.json

@@ -0,0 +1,3 @@
+{
+    "name": "nanostack-upper"


I'll propose "nanostack-adaptation"

i believe that this change is in @theotherjimmy original PR

@SeppoTakalo Actually, that's a hack that I have not yet removed. Could you comment on the appropriate folders to label such that we can completely exclude nanostack code from the build?

Do you mean that all folders within /features/nanostack/ should have their own mbed_lib.json files?

Perhaps. It depends on what you would consider a complete "library", that could be turned on/off as one. If the code within the subdirectories in nanostack can be enabled independently, then it would make sense to have mbed_lib.json in the root so that a user could use requires on that library.

Does this image help?

There are clear dependencies that can be expressed, so maybe it makes sense to all components being separate.

nanostack-eventloop is actually used also with Mbed Client.

Couple of helper libraries also missing from the picture:

features/frameworks/mbed-client-randlib (used by nanostack)

features/frameworks/mbed-coap (used by coap-service and Pelion Client)

features/frameworks/mbed-trace (used by Nanostack and Pelion Client, and various other libraries)

features/frameworks/nanostack-libservice (used by pretty much all Nanostack libraries and even Pelion Client).

So.. after a longer thought.. it seems that "features/nanostack" should be empty, no .lib files there, and all that is inside it, should have their equivalent .lib files.

@SeppoTakalo @theotherjimmy Could you move this comment to #9561?

features/nanostack/nanostack-interface/mbed_lib.json

davidsaada

LGTM (reviewing storage related changes).

orenc17 · 2019-02-07T13:40:14Z

@SeppoTakalo @theotherjimmy
i've moved the problematic mbed_lib.json
now every directory inside features/nanostack has its own mbed_lib.json

SeppoTakalo

I can approve following .lib files:

mbed-client-cli
mbed-client-randlib
mbed-coap
nanostack-libservice
coap-service
nanostack-interface

Technically I cannot review changes to the tooling as I have not enough knowledge about the design.

cmonr · 2019-02-12T21:39:44Z

CI started

mbed-ci · 2019-02-13T00:04:09Z

Test run: FAILED

Summary: 3 of 8 test jobs failed
Build number : 1
Build artifacts

Failed test jobs:

jenkins-ci/mbed-os-ci_build-GCC_ARM
jenkins-ci/mbed-os-ci_build-ARM
jenkins-ci/mbed-os-ci_build-IAR

cmonr · 2019-02-13T02:00:09Z

One of the errors:

Scan: mbed-os-example-blinky
Traceback (most recent call last):
  File "/builds/ws/mbed-os-ci_build-GCC_ARM@3/examples/mbed-os-example-blinky/mbed-os/tools/make.py", line 74, in wrapped_build_project
    src_dir, build_dir, mcu, *args, **kwargs
  File "/builds/ws/mbed-os-ci_build-GCC_ARM@3/examples/mbed-os-example-blinky/mbed-os/tools/build_api.py", line 544, in build_project
    src_paths, toolchain, inc_dirs=inc_dirs)
  File "/builds/ws/mbed-os-ci_build-GCC_ARM@3/examples/mbed-os-example-blinky/mbed-os/tools/resources/__init__.py", line 568, in scan_with_toolchain
    toolchain.config.load_resources(self)
  File "/builds/ws/mbed-os-ci_build-GCC_ARM@3/examples/mbed-os-example-blinky/mbed-os/tools/config/__init__.py", line 1319, in load_resources
    raise ConfigException(message)
ConfigException: library 'psa' requires 'flashiap-block-device' which is not present
[mbed] ERROR: "/usr/bin/python" returned error.

cmonr · 2019-02-13T18:42:04Z

CI started (for now).

Still expected reviewer feedback

cmonr · 2019-02-13T18:43:12Z

@orenc17 Fyi, this will also need a Release Notes section.

cmonr · 2019-02-13T20:56:40Z

@mbed-os-mesh @ARMmbed/mbed-os-pan @yossi2le Any thoughts?

mbed-ci · 2019-02-13T21:04:47Z

Test run: SUCCESS

Summary: 12 of 12 test jobs passed
Build number : 2
Build artifacts

yossi2le · 2019-02-14T09:02:24Z

I have taken a look at the changes and they look ok for me.
I will be happy to see this merged. Cause I am one of the clients for these changes :)

ciarmcom requested review from davidsaada, theotherjimmy, yossi2le and a team February 6, 2019 12:00

ciarmcom added the needs: review label Feb 6, 2019

jeromecoutant reviewed Feb 6, 2019

View reviewed changes

theotherjimmy approved these changes Feb 6, 2019

View reviewed changes

SeppoTakalo reviewed Feb 6, 2019

View reviewed changes

features/nanostack/nanostack-interface/mbed_lib.json Outdated Show resolved Hide resolved

davidsaada approved these changes Feb 6, 2019

View reviewed changes

mikisch81 mentioned this pull request Feb 7, 2019

Tools changes for bare metal #9561

Merged

0xc0170 added the needs: preceding PR label Feb 7, 2019

SeppoTakalo approved these changes Feb 7, 2019

View reviewed changes

mikisch81 mentioned this pull request Feb 13, 2019

Some build issues with PSA_Target on M2351 #9699

Closed

Oren Cohen added 2 commits February 13, 2019 20:36

Storage mbed_lib.json files

bb775c2

Add PSA mbed-lib.json

b5e8492

cmonr added needs: CI and removed needs: preceding PR needs: CI labels Feb 13, 2019

cmonr added the release-version: 5.12.0-rc1 label Feb 13, 2019

yossi2le approved these changes Feb 14, 2019

View reviewed changes

0xc0170 approved these changes Feb 14, 2019

View reviewed changes

0xc0170 removed request for a team February 14, 2019 10:36

0xc0170 added ready for merge and removed needs: review labels Feb 14, 2019

cmonr merged commit c07410d into ARMmbed:master Feb 14, 2019

cmonr removed the ready for merge label Feb 14, 2019

Bare metal mbed_lib updates #9628

Bare metal mbed_lib updates #9628

Uh oh!

Conversation

orenc17 commented Feb 6, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Pull request type

Reviewers

Release notes

Uh oh!

ciarmcom commented Feb 6, 2019

Uh oh!

Choose a reason for hiding this comment

Uh oh!

orenc17 Feb 6, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

theotherjimmy left a comment

Choose a reason for hiding this comment

Uh oh!

orenc17 commented Feb 6, 2019

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

davidsaada left a comment

Choose a reason for hiding this comment

Uh oh!

orenc17 commented Feb 7, 2019

Uh oh!

SeppoTakalo left a comment

Choose a reason for hiding this comment

Uh oh!

cmonr commented Feb 12, 2019

Uh oh!

mbed-ci commented Feb 13, 2019

Uh oh!

cmonr commented Feb 13, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

cmonr commented Feb 13, 2019

Uh oh!

cmonr commented Feb 13, 2019

Uh oh!

cmonr commented Feb 13, 2019

Uh oh!

mbed-ci commented Feb 13, 2019

Uh oh!

yossi2le commented Feb 14, 2019

Uh oh!

Uh oh!

orenc17 commented Feb 6, 2019 •

edited

Loading

orenc17 Feb 6, 2019 •

edited

Loading

cmonr commented Feb 13, 2019 •

edited

Loading