Release candidate for mbed-os-5.11.4 #9646

adbridge · 2019-02-08T12:51:15Z

No description provided.

adbridge · 2019-02-08T12:52:52Z

CI started

mbed-ci · 2019-02-08T13:42:10Z

Test run: FAILED

Summary: 3 of 8 test jobs failed
Build number : 1
Build artifacts

Failed test jobs:

jenkins-ci/mbed-os-ci_build-ARM
jenkins-ci/mbed-os-ci_build-GCC_ARM
jenkins-ci/mbed-os-ci_build-IAR

vmedcy · 2019-02-08T14:25:01Z

@adbridge: apparently #9481 is not applied correctly in release-candidate branch: c424163 should be applied to targets/TARGET_Cypress/TARGET_PSOC6, not targets/TARGET_Cypress/TARGET_PSOC6_FUTURE, like here: 6d932c6. Also, cd98eb6 is missed (should follow immediately after 6b0658d).
The order of commits is important (due to TARGET_PSOC6 -> TARGET_PSOC6_FUTURE rename).

adbridge · 2019-02-08T15:50:46Z

@vmedcy all the commits on the PR should be there, we just use git am -3 to take all the commits from the original PR and merge them across. If that has not worked correctly then it looks like an issue with the original PR :(

adbridge · 2019-02-08T15:52:09Z

I'll try reverting the PR and then try cherry picking each individual commit from #4981 in the order they are on the PR

adbridge · 2019-02-08T16:18:10Z

@vmedcy OK there is something seriously wrong with the commits on #9481 . This is the commit list in the order they were put on the PR
cd98eb6
6b0658d
4713de2
6d932c6
432c29d
769b725
7aeb2ff
5c47eb4
a304c22
a168115
022bd8e
aebf242

When I try to cherry pick the first commit across , it gives an empty commit! If I allow that and move on, the next 2 come across ok and then 6d932c6 fails. Currently I don't see how this can come across as it stands...

vmedcy · 2019-02-08T16:31:11Z

@abridge: the correct order is:
6b0658d
cd98eb6
4713de2
6d932c6
432c29d
769b725
7aeb2ff
5c47eb4
a304c22
a168115
022bd8e
aebf242

This is the order the commits appear in the git log as well as github web interface:
https://github.com/ARMmbed/mbed-os/commits/master

How do you get the commit order mentioned in the post? It is wrong.

adbridge · 2019-02-08T16:37:09Z

https://github.com/ARMmbed/mbed-os/pull/9481/commits
I would normally expect that to be in the right order

Let me try cherry-picking in the order you have specified

#justnitpickythings

…er.h

…and DTLSSocketWrapper.h

…tools compatibility This fixes issue #9611

Compilation error was due to due to bug in gcc.py

Add "-mfpu=none" compilation flag

$(file > [email protected], $(filter %.o, $^)) is not supported in GNU Make 3.81. Create the linker response file with pipe redirect from echo command. This is tested with Cygwin make and make 3.8.1 shipped with macOS. Also, change the linker responce file name to .link_options.txt. This is an internal file, not a build artifact.

If config is specified, check that part size is not exceeding the region. Normally we now assume that part.maxaddr() can be beyond end of rom.

…size

The targets/TARGET_Cypress/TARGET_PSOC6 is dedicated to the mbed-os HAL and PSoC 6 MCU targets developed by Cypress Semiconductor. Move the existing port developed by Future Electronics to TARGET_PSOC_FUTURE and update the labels in targets.json appropriately.

Copy the porting layer from TARGET_PSOC6_FUTURE to TARGET_PSOC6. This commit is intended to make the history and changes applied easier to follow. ipcpipe_transport.c, ipcpipe_transport.h, rpc_api.h, rpc_defs.h are excluded (not used by Cypress port). PeripheralNames.h is moved to BSP layer introduced in subsequent commits (the peripheral names and count are board-specific).

Integrate the latest fixes to the PSoC 6 HAL.

Exclude the labels from inherited FUTURE_SEQUANA targets.

Code generated for pioneer kits: * CY8CKIT-062-4343W * CY8CKIT-062-BLE * CY8CKIT-WIFI-BT Prototyping boards: * CY8CPROTO-062-4343W The source is generated with ModusToolbox Device Configurator. The origin design.modus files used to produce the GeneratedSource will be submitted in the consequent pull requests.

TARGET_CYW4343X Bluetooth HCI driver is specific to STM32 targets derived from USI_WM_BN_BM_22. Move the driver implementation to TARGET_STM folder to not interfere with Cypress implementation at TARGET_Cypress/TARGET_CYW43XXX/HCIDriver.cpp that is enabled for PSoC 6 targets which also include the CYW4343X label.

Add Cypress HCI driver implementation in TARGET_Cypress directory. Update targets.json to enable CORDIO stack for Cypress PSoC 6 boards with CYW43XXX radios with compatible HCI driver implementation: CYW4343W and CYW43012.

Add prebuilt WICED libraries for the PSoC 6 boards with WICED radios: * TARGET_CY8CKIT_062_4343W * TARGET_CY8CKIT_062_WIFI_BT * TARGET_CY8CPROTO_062_4343W * TARGET_CYW943012P6EVB_01 Add required extra labels to the PSoC 6 targets in targets.json: (PSOC6_01/02 labels are used during the library compilation).

Set the default network interface type as WIFI for Cypress targets with on-board WICED Wi-Fi module.

adbridge · 2019-02-08T17:00:09Z

@vmedcy thanks for that commit order, they have all come across cleanly now, so fingers crossed we should get a pass this time !

mbed-ci · 2019-02-08T19:30:20Z

Test run: SUCCESS

Summary: 12 of 12 test jobs passed
Build number : 2
Build artifacts

vmedcy · 2019-02-12T13:48:22Z

Hi @adbridge:

https://github.com/ARMmbed/mbed-os/pull/9481/commits
I would normally expect that to be in the right order

Let me try cherry-picking in the order you have specified

I figured out why the commit order on github page https://github.com/ARMmbed/mbed-os/pull/9481/commits is wrong.
Each git commit has author date and commit date. Author date is preserved during rebase/amend, unlike commit date which is always updated dynamically by git.
GitHub displays the author date in the web UI, but sorts the commits by the commit date.
Commit dates of both cd98eb6 and 6b0658d are identical: 2019-02-06 18:56:19, because the second commit was applied non-interactively during the rebase operation.

Learning: do not rely on the commit order in the GitHub web interface :)

adbridge requested a review from a team February 8, 2019 12:51

adbridge force-pushed the release-candidate branch from ef1dd33 to 1e59499 Compare February 8, 2019 16:04

Ari Parkkila and others added 20 commits February 8, 2019 16:45

Cellular: Update cellular documentation

01f1c41

Cellular: Remove non-API folders from Doxygen

5352d40

Fix netsocket Doxygen group

f6b44bd

Formatting tweaks

4831d12

#justnitpickythings

backticks

9e79418

Doxygen corrections to: - DTLSSocket.h - TLSSocket.h - TLSSocketWrapp…

222a36c

…er.h

Fix NetworkInterface grouping

81108c6

Create new netinterface Doxygen group

1ab806b

SocketAddress doxygen cleanup

3f94303

WifiInterface doxygen cleanup

c2718e3

Doxygen corrections to DTLSSocket.h, TLSSocket.h, TLSSocketWrapper.h …

02e2704

…and DTLSSocketWrapper.h

Remove extra @param values

1b40e43

Fix DNS grouping

5a662b4

Add more documentation to Socket classes.

4d6e99c

Hide protected start_handshake

8a4674d

removing 'easy to use'

8d84a14

typo fixes, future->present

07cd9a1

Review changes

259d726

editorial changes, punctuation

24803d2

grammatical corrections

0117ec4

lrusinowicz and others added 22 commits February 8, 2019 16:50

FUTURE_SEQUANA: Removed special "tags" from M0 hex images for better …

c46215d

…tools compatibility This fixes issue #9611

Fix cortex-m33-S compile error

f869e9a

Compilation error was due to due to bug in gcc.py

Fix cortex-m33-S armlink error

0f15c7f

Add "-mfpu=none" compilation flag

Implement Linker command/response files in make export

ddddb6f

tools: check part size is not exceeding region size

0355876

If config is specified, check that part size is not exceeding the region. Normally we now assume that part.maxaddr() can be beyond end of rom.

tools: build_api_test: add test to detect when part overflows region …

e7985fd

…size

Added MBED_APP_START to linker script

d046c91

Correct the dsp flag from no_dsp to nodsp

fdb1a4f

Update Mbed version block

318af23

PSOC6: add the latest Cypress PDL sources

34be4ac

PSOC6: update the HAL implementation to latest PDL

3319f73

Integrate the latest fixes to the PSoC 6 HAL.

PSOC6: add CRC and TRNG APIs

5767771

Exclude the labels from inherited FUTURE_SEQUANA targets.

PSOC6: add BSPs for Cypress kits

296f8cb

Add prebuilt CM0+ images for Cypress kits

d1f7e7c

PSOC6: add network-default-interface-type to Cypress boards

33d779f

Set the default network interface type as WIFI for Cypress targets with on-board WICED Wi-Fi module.

adbridge force-pushed the release-candidate branch from 1e59499 to 33d779f Compare February 8, 2019 16:59

0xc0170 approved these changes Feb 11, 2019

View reviewed changes

0xc0170 added the ready for merge label Feb 11, 2019

0xc0170 merged commit ecb3c8c into mbed-os-5.11 Feb 11, 2019

0xc0170 removed the ready for merge label Feb 11, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Release candidate for mbed-os-5.11.4 #9646

Release candidate for mbed-os-5.11.4 #9646

Uh oh!

adbridge commented Feb 8, 2019

Uh oh!

adbridge commented Feb 8, 2019

Uh oh!

mbed-ci commented Feb 8, 2019

Uh oh!

vmedcy commented Feb 8, 2019

Uh oh!

adbridge commented Feb 8, 2019

Uh oh!

adbridge commented Feb 8, 2019

Uh oh!

adbridge commented Feb 8, 2019 •

edited

Loading

Uh oh!

vmedcy commented Feb 8, 2019

Uh oh!

adbridge commented Feb 8, 2019 •

edited

Loading

Uh oh!

adbridge commented Feb 8, 2019

Uh oh!

mbed-ci commented Feb 8, 2019

Uh oh!

vmedcy commented Feb 12, 2019

Uh oh!

Uh oh!

Release candidate for mbed-os-5.11.4 #9646

Release candidate for mbed-os-5.11.4 #9646

Uh oh!

Conversation

adbridge commented Feb 8, 2019

Uh oh!

adbridge commented Feb 8, 2019

Uh oh!

mbed-ci commented Feb 8, 2019

Test run: FAILED

Uh oh!

vmedcy commented Feb 8, 2019

Uh oh!

adbridge commented Feb 8, 2019

Uh oh!

adbridge commented Feb 8, 2019

Uh oh!

adbridge commented Feb 8, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

vmedcy commented Feb 8, 2019

Uh oh!

adbridge commented Feb 8, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

adbridge commented Feb 8, 2019

Uh oh!

mbed-ci commented Feb 8, 2019

Test run: SUCCESS

Uh oh!

vmedcy commented Feb 12, 2019

Uh oh!

Uh oh!

adbridge commented Feb 8, 2019 •

edited

Loading

adbridge commented Feb 8, 2019 •

edited

Loading