Skip to content

Fix dependencies of platform partition #9702

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 13, 2019
Merged

Fix dependencies of platform partition #9702

merged 1 commit into from
Feb 13, 2019

Conversation

orenc17
Copy link
Contributor

@orenc17 orenc17 commented Feb 13, 2019

Description

Fix an issue in PSA partitions

  • Note to maintainers a PR updating the secure binaries will be opened later today

Pull request type

[X] Fix
[ ] Refactor
[ ] Target update
[ ] Functionality change
[ ] Docs update
[ ] Test update
[ ] Breaking change

Reviewers

@ARMmbed/mbed-os-psa

Copy link
Contributor

@mikisch81 mikisch81 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note to myself, update #9653 as well

@0xc0170
Copy link
Contributor

0xc0170 commented Feb 13, 2019

Fix an issue in PSA partitions

What issue? How this addresses it ? Can you expand the commit msg, the code change looks simple so the msg could also be short but informative

@orenc17
Copy link
Contributor Author

orenc17 commented Feb 13, 2019

The issue is that the platform partition on PSA boards calls its_reset API,
on K64F its a non-issue because the lack of SPM but on FUTURE_SEQUANA it will crash in the secure side

The change looks big due to the auto-generation of SPM code

@mbed-ci
Copy link

mbed-ci commented Feb 13, 2019

Test run: FAILED

Summary: 1 of 8 test jobs failed
Build number : 1
Build artifacts

Failed test jobs:

  • jenkins-ci/mbed-os-ci_mbed2-build-IAR

@cmonr
Copy link
Contributor

cmonr commented Feb 13, 2019

Restarting CI.

Single job failure did not list any FAIL artifacts, indicating something likely went wring within Jenkins

@cmonr
Copy link
Contributor

cmonr commented Feb 13, 2019

And sure enough, it looks like the single job hit a GitHub 502 timeout.

Interesting...

@mbed-ci
Copy link

mbed-ci commented Feb 13, 2019

Test run: SUCCESS

Summary: 12 of 12 test jobs passed
Build number : 2
Build artifacts

@cmonr cmonr merged commit 704a1cb into ARMmbed:master Feb 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants