Cellular: fix onboard modems powering failure. #9706
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AriParkkila
approved these changes
Feb 13, 2019
|
@jarvte, thank you for your changes. |
AriParkkila
approved these changes
Feb 13, 2019
| @@ -19,7 +19,7 @@ | |||
| #include "cellular/onboard_modem_api.h" | |||
| #include "UARTSerial.h" | |||
| #include "ONBOARD_TELIT_HE910.h" | |||
| #include "CellularLog.h" | |||
| #include "ThisThread.h" | |||
There was a problem hiding this comment.
tr_debug may need CellularLog, if not coming from other includes..?
There was a problem hiding this comment.
Once this is resolved, will start CI
There was a problem hiding this comment.
Added Cellularlog to both targets.
cmonr
approved these changes
Feb 13, 2019
cmonr
added
needs: work
release-version: 5.11.5
release-version: 5.12.0-rc1
and removed
needs: review
release-version: 5.11.5
labels
jarvte
force-pushed
the
fix_powering_onboard_modems
branch
from
00ef13c to
8b09108
Compare
AriParkkila
approved these changes
Feb 14, 2019
Why aren't this captured in the commit msg? |
Don't call soft power on if device was already powered. Some modems need to wait before sending anything to modem after soft powering.
jarvte
force-pushed
the
fix_powering_onboard_modems
branch
from
8b09108 to
e4018bd
Compare
Updated commit msg. |
|
CI started |
Test run: SUCCESSSummary: 12 of 12 test jobs passed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix onboard modem power up failures.
Pull request type
Reviewers
@AriParkkila