Skip to content

Conversation

netanelgonen
Copy link
Contributor

remove a workaround that was saved for future use.
after this change, if the type is not supported the psa_crypto will return the error code for unsupported

Description

Pull request type

[X] Fix
[ ] Refactor
[ ] Target update
[ ] Functionality change
[ ] Docs update
[ ] Test update
[ ] Breaking change

Reviewers

@itayzafrir

Release Notes

@ciarmcom ciarmcom requested review from itayzafrir and a team February 19, 2019 12:00
@ciarmcom
Copy link
Member

@netanelgonen, thank you for your changes.
@itayzafrir @ARMmbed/mbed-os-maintainers please review.

Copy link
Contributor

@itayzafrir itayzafrir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@0xc0170
Copy link
Contributor

0xc0170 commented Feb 19, 2019

CI started

if the type is not supported the psa_crypto will return the error code
for unsupported
@0xc0170
Copy link
Contributor

0xc0170 commented Feb 19, 2019

Why was this rebased? no comment left

@0xc0170
Copy link
Contributor

0xc0170 commented Feb 19, 2019

CI restarted

@netanelgonen
Copy link
Contributor Author

@0xc0170 This was not rebased only a small change inserted,
no comment was left here but @itayzafrir requested a changing "face to face"
additional parentheses around the 2nd part of the if statement

@mbed-ci
Copy link

mbed-ci commented Feb 19, 2019

Test run: SUCCESS

Summary: 12 of 12 test jobs passed
Build number : 1
Build artifacts

@cmonr
Copy link
Contributor

cmonr commented Feb 19, 2019

The above result was prior to the rebase.

Another comment will be posted once the current CI run completes.

@mbed-ci
Copy link

mbed-ci commented Feb 19, 2019

Test run: SUCCESS

Summary: 12 of 12 test jobs passed
Build number : 2
Build artifacts

@0xc0170
Copy link
Contributor

0xc0170 commented Feb 22, 2019

Moved to 5.12 due to failures with 5.11 branch

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants