Skip to content

Conversation

davidsaada
Copy link
Contributor

Description

Remove unnecessary prints in FileSystemStore class. Prints were mainly used during debug process and are not necessary now.
In addition, when file name included unprintable characters, these prints were the reason for Internal JIRA ticket IOTSTOR-772, making the test suite crash due to its inability to display unprintable characters.

Pull request type

[x] Fix
[ ] Refactor
[ ] Target update
[ ] Functionality change
[ ] Docs update
[ ] Test update
[ ] Breaking change

@ciarmcom ciarmcom requested review from a team February 24, 2019 14:00
@ciarmcom
Copy link
Member

@davidsaada, thank you for your changes.
@ARMmbed/mbed-os-storage @ARMmbed/mbed-os-maintainers please review.

Copy link
Contributor

@theamirocohen theamirocohen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@NirSonnenschein
Copy link
Contributor

started CI

@mbed-ci
Copy link

mbed-ci commented Feb 24, 2019

Test run: SUCCESS

Summary: 12 of 12 test jobs passed
Build number : 1
Build artifacts

@0xc0170 0xc0170 merged commit 3fd8f1b into ARMmbed:master Feb 25, 2019
TaniaMirzin pushed a commit to TaniaMirzin/mbed-os that referenced this pull request Mar 3, 2019
@davidsaada davidsaada deleted the david_fsst_remove_unnecessary_prints branch March 16, 2019 08:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants