Skip to content

Fix cordio gatts configuring write permission #9843

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 27, 2019
Merged

Fix cordio gatts configuring write permission #9843

merged 1 commit into from
Feb 27, 2019

Conversation

desmond-blue
Copy link
Contributor

Description

When configuring write permission of an inserted descriptor, should check the value of _write_allowed.

Pull request type

[x] Fix
[ ] Refactor
[ ] Target update
[ ] Functionality change
[ ] Docs update
[ ] Test update
[ ] Breaking change

Reviewers

Release Notes

@cmonr cmonr requested a review from a team February 26, 2019 03:45
pan-
pan- approved these changes Feb 26, 2019
View reviewed changes
Copy link
Member

@pan- pan- left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch. I don't think we tests writeable descriptors at the moment.

@cmonr
Copy link
Contributor

cmonr commented Feb 27, 2019

CI started

@mbed-ci
Copy link

mbed-ci commented Feb 27, 2019

Test run: FAILED

Summary: 1 of 12 test jobs failed
Build number : 1
Build artifacts

Failed test jobs:

  • jenkins-ci/mbed-os-ci_greentea-test

@0xc0170
Copy link
Contributor

0xc0170 commented Feb 27, 2019

Restarted tests, this looks like device/master problem, will be monitoring

@0xc0170 0xc0170 merged commit 7a5831a into ARMmbed:master Feb 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pan- pan- pan- approved these changes

@0xc0170 0xc0170 0xc0170 approved these changes

+1 more reviewer

@paul-szczepanek-arm paul-szczepanek-arm paul-szczepanek-arm approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
release-version: 5.12.0-rc1 risk: G
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@desmond-blue @cmonr @mbed-ci @0xc0170 @pan- @paul-szczepanek-arm