Skip to content

ESP8266: receive is able to handle device busy indication #9871

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 1, 2019
Merged

ESP8266: receive is able to handle device busy indication #9871

merged 1 commit into from
Mar 1, 2019

Conversation

VeijoPesonen
Copy link
Contributor

Description

Socket receive must return NSAPI_ERROR_WOULD_BLOCK if device is busy doing something else, like sending data etc.

Pull request type

[X] Fix
[ ] Refactor
[ ] Target update
[ ] Functionality change
[ ] Docs update
[ ] Test update
[ ] Breaking change

Reviewers

@michalpasztamobica
@SeppoTakalo

Release Notes

@VeijoPesonen
Copy link
Contributor Author

@teetak01 for your information

@ciarmcom
Copy link
Member

@VeijoPesonen, thank you for your changes.
@michalpasztamobica @SeppoTakalo @ARMmbed/mbed-os-ipcore @ARMmbed/mbed-os-maintainers please review.

michalpasztamobica
michalpasztamobica approved these changes Feb 27, 2019
View reviewed changes
Copy link
Contributor

@michalpasztamobica michalpasztamobica left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Out of curiosity - have you ever seen the "else" branch entered and DEVICE_ERROR reported?

@VeijoPesonen
Copy link
Contributor Author

VeijoPesonen commented Feb 27, 2019 •
edited
Loading

Out of curiosity - have you ever seen the "else" branch entered and DEVICE_ERROR reported?

Noup, but on the other hand I wouldn't have expected that we would hit

mbed-os/components/wifi/esp8266-driver/ESP8266/ESP8266.cpp

Line 1154 in 688a4e4

MBED_ERROR(MBED_MAKE_ERROR(MBED_MODULE_DRIVER, MBED_ERROR_CODE_ENOMSG), \
neither...

@adbridge
Copy link
Contributor

This is marked internally as a critical fix so we should try and take it into 5.12

@0xc0170
Copy link
Contributor

0xc0170 commented Feb 28, 2019

CI started

@mbed-ci
Copy link

mbed-ci commented Feb 28, 2019

Test run: SUCCESS

Summary: 13 of 13 test jobs passed
Build number : 1
Build artifacts

@mbed-ci
Copy link

mbed-ci commented Feb 28, 2019

Test run: SUCCESS

Summary: 13 of 13 test jobs passed
Build number : 2
Build artifacts

@cmonr cmonr merged commit b5878b1 into ARMmbed:master Mar 1, 2019
@VeijoPesonen VeijoPesonen deleted the bugfix-esp8266-recv_busy branch March 1, 2019 11:02
@michalpasztamobica michalpasztamobica mentioned this pull request Dec 23, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0xc0170 0xc0170 0xc0170 approved these changes

@SeppoTakalo SeppoTakalo SeppoTakalo approved these changes

@michalpasztamobica michalpasztamobica michalpasztamobica approved these changes

Assignees
No one assigned
Labels
release-version: 5.12.0-rc1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@VeijoPesonen @ciarmcom @adbridge @0xc0170 @mbed-ci @SeppoTakalo @michalpasztamobica @cmonr