-
Notifications
You must be signed in to change notification settings - Fork 3k
Fix of Buffered Serial RX/TX crash problem on REALTEK_RTL8195am #9923
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix of Buffered Serial RX/TX crash problem on REALTEK_RTL8195am #9923
Conversation
Remove the interrupt disable function to fix the logUART rx error when inputting multiple characters simultaneously in buffered serial mode.
@AdamZhang0124, thank you for your changes. |
This cannot be verified anymore. |
Good point! @AdamZhang0124 Are you planning to re-enable |
I didn't disable MCU_RTL8195A. Our target seems to be excluded after the release of 5.12 |
Hi, Adam@Realtek is re-building the libraries for RTL8195AM to support IAR8. He'll submit a PR to the master with the updated libraries once it's done. This PR can only be processed until MCU_RTL8195A is re-enabled. Some background info. Realtek did submit a PR to include updated libraries for IAR8 support via below PR but for some reason that was not finished and lost in the pond. |
@AdamZhang0124 @samchuarm Would there happen to be any updates to share? |
Hi @cmonr , |
@AdamZhang0124 Do you have a full test log that could be used to debug the problem? |
Yes, this is the newest full test log that I ran yesterday for your reference. |
@flit @brianesquilona Would y'all know of any way to help out here? @AdamZhang0124 Is this only an IAR issue? |
What is the problem? I can't parse anything out of the log file… |
@flit @brianesquilona Sorry, I may have jumped the gun a bit. @AdamZhang0124 It looks like the target is hard faulting after attempting to initialize
Are you also aware that this is being printed? Is this normal?
|
From the logs we see lot of hard faults
@AdamZhang0124 can you please confirm if blinky is working with library update to IAR 8.32 ? |
Hi @studavekar , |
@AdamZhang0124 If you are still having issues, create a new issue. This fix shall be closed until realtek MCU is reenabled (can be tested). |
Hi @0xc0170 , for your information, the issue #9206 that blocks the device from compiling is still in progress. Thanks! |
I propose to close this PR and reopen with an update. Please do once this is unblocked. |
This PR addresses the issue of #8081.
It removes 'interrupt disable' in 'serial_loguart_irq_handler' function in "serial_api.c".
Description
Pull request type
Reviewers
Release Notes