Skip to content

tsi/main.cpp is using wrong printf format #9984

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 15, 2019

Conversation

janjongboom
Copy link
Contributor

Description

% needs to be escaped as well. Not sure if we accept PRs on unsupported features.

Pull request type

[X] Fix
[ ] Refactor
[ ] Target update
[ ] Functionality change
[ ] Docs update
[ ] Test update
[ ] Breaking change

Reviewers

Release Notes

`%` needs to be escaped as well.
@0xc0170
Copy link
Contributor

0xc0170 commented Mar 7, 2019

% needs to be escaped as well. Not sure if we accept PRs on unsupported features.

We don't.

cc @bulislaw

@ciarmcom ciarmcom requested a review from a team March 7, 2019 16:00
@ciarmcom
Copy link
Member

ciarmcom commented Mar 7, 2019

@janjongboom, thank you for your changes.
@ARMmbed/mbed-os-maintainers please review.

@bulislaw
Copy link
Member

bulislaw commented Mar 7, 2019

I don't see an issue accepting changes to the unsupported folders as long as it doesn't create impression that we support it.

@0xc0170
Copy link
Contributor

0xc0170 commented Mar 8, 2019

@ARMmbed/mbed-os-maintainers No release label set here for unsupported folder changes.

@cmonr
Copy link
Contributor

cmonr commented Mar 13, 2019

@ARMmbed/mbed-os-maintainers No release label set here for unsupported folder changes.

Had to think about that for a moment. Makes sense, in a weird way.

@0xc0170
Copy link
Contributor

0xc0170 commented Mar 15, 2019

No more changes are expected there.

This was added to the rollup PR #10116 and it's currently in CI. If any new commit comes, please let us know immediately.

@0xc0170 0xc0170 merged commit a5c6d42 into ARMmbed:master Mar 15, 2019
@0xc0170 0xc0170 removed the needs: CI label Mar 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants