Skip to content

Remove intervaltree from requirements.txt for mbed-os as it contradic… #9998

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 15, 2019
Merged

Remove intervaltree from requirements.txt for mbed-os as it contradic… #9998

merged 1 commit into from
Mar 15, 2019

Conversation

linlingao
Copy link
Contributor

…ts pyocd requirements

Description

Remove version requirement of intervaltree because it contradicts what pyocd requires.

Pull request type

[x] Fix
[ ] Refactor
[ ] Target update
[ ] Functionality change
[ ] Docs update
[ ] Test update
[ ] Breaking change

Reviewers

Release Notes

@linlingao linlingao requested a review from bridadan March 7, 2019 21:24
@linlingao
Copy link
Contributor Author

This was suggested by Brain D.

bridadan
bridadan approved these changes Mar 7, 2019
View reviewed changes
Copy link
Contributor

@bridadan bridadan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was suggested by Brain D.

Passing the blame to me I see! 😛 Looks great, thanks!

@cmonr
Copy link
Contributor

cmonr commented Mar 8, 2019

Soooo, anyone want to provide a link to PyOCD where it shows the conflict?

@0xc0170 0xc0170 requested a review from cmonr March 8, 2019 10:07
@bridadan
Copy link
Contributor

bridadan commented Mar 8, 2019

@cmonr in the setup.py: https://github.com/mbedmicro/pyOCD/blob/master/setup.py#L56

@cmonr
Copy link
Contributor

cmonr commented Mar 12, 2019

@bridadan Thoughts on increasing the major versions instead of outright removing the dependency?

@bridadan
Copy link
Contributor

The Mbed OS tools in this repository do not depend on the intervaltree package, so I think its appropriate to remove it.

@cmonr
Copy link
Contributor

cmonr commented Mar 12, 2019

The Mbed OS tools in this repository do not depend on the intervaltree package

Oh. Well what do you know. Only one instance of "intervaltree", and it's this instance.

@0xc0170 0xc0170 mentioned this pull request Mar 15, 2019
Merged
@0xc0170
Copy link
Contributor

0xc0170 commented Mar 15, 2019

No more changes are expected there.

This was added to the rollup PR #10116 and it's currently in CI. If any new commit comes, please let us know immediately.

@0xc0170 0xc0170 merged commit 68399d7 into ARMmbed:master Mar 15, 2019
@0xc0170 0xc0170 removed the needs: CI label Mar 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cmonr cmonr cmonr approved these changes

@0xc0170 0xc0170 0xc0170 approved these changes

@bridadan bridadan bridadan approved these changes

Assignees
No one assigned
Labels
release-version: 5.12.1 rollup PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@linlingao @cmonr @bridadan @0xc0170