Skip to content

UDS-1933: feat(app-rfi): added a patch for react-phone-input-2 #1470

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 5, 2025
Merged

UDS-1933: feat(app-rfi): added a patch for react-phone-input-2 #1470

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ec7cbb2
feat(app-rfi): added a patch for react-phone-input-2
juanmitriatti Feb 11, 2025
21e9a36
feat(app-rfi): added react-phone-input-2 patch to resolutions in pack…
juanmitriatti Feb 26, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
181 changes: 181 additions & 0 deletions .yarn/patches/react-phone-input-2-npm-2.15.1-f7a7dd913b.patch
View file
Open in desktop

Large diffs are not rendered by default.

3 changes: 2 additions & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -103,7 +103,8 @@
},
"resolutions": {
"cosmiconfig": "<9",
"lerna": "^6.6.2"
"lerna": "^6.6.2",
"react-phone-input-2": "patch:react-phone-input-2@npm%3A2.15.1#~/.yarn/patches/react-phone-input-2-npm-2.15.1-f7a7dd913b.patch"
},
"config": {
"commitizen": {
Expand Down
2 changes: 1 addition & 1 deletion packages/app-rfi/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -84,7 +84,7 @@
"@asu/unity-react-core": "workspace:^",
"formik": "^2.1.4",
"prop-types": "^15.7.2",
"react-phone-input-2": "^2.14.0",
"react-phone-input-2": "2.15.1",
"reactstrap": "^9",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Try this:
./package.json resolutions have to be at the workspace root

{
  ...
  "dependencies": {
    ...
   },
   "resolutions": {
      "react-phone-input-2": "patch:react-phone-input-2@npm%3A2.15.1#~/.yarn/patches/react-phone-input-2-npm-2.15.1-f7a7dd913b.patch"
   },
}

./packages/app-rfi/package.json since our patch is for 2.15.1 remove the ^ and set the exact version

{
  ...
  "dependencies": {
    ...
    "react-phone-input-2": "2.15.1",
    ...
   },
}

"yup": "^0.28.1",
"yup-phone": "^1.2.19"
Expand Down
21 changes: 19 additions & 2 deletions yarn.lock
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -113,7 +113,7 @@ __metadata:
jsdom-screenshot: "npm:^4.0.0"
postcss: "npm:^8.4.19"
prop-types: "npm:^15.7.2"
react-phone-input-2: "npm:^2.14.0"
react-phone-input-2: "npm:2.15.1"
reactstrap: "npm:^9"
semantic-release: "npm:^22"
semantic-release-monorepo: "npm:^8.0.2"
Expand Down Expand Up @@ -28018,7 +28018,7 @@ __metadata:
languageName: node
linkType: hard

"react-phone-input-2@npm:^2.14.0":
"react-phone-input-2@npm:2.15.1":
version: 2.15.1
resolution: "react-phone-input-2@npm:2.15.1"
dependencies:
Expand All @@ -28035,6 +28035,23 @@ __metadata:
languageName: node
linkType: hard

"react-phone-input-2@patch:react-phone-input-2@npm%3A2.15.1#~/.yarn/patches/react-phone-input-2-npm-2.15.1-f7a7dd913b.patch":
version: 2.15.1
resolution: "react-phone-input-2@patch:react-phone-input-2@npm%3A2.15.1#~/.yarn/patches/react-phone-input-2-npm-2.15.1-f7a7dd913b.patch::version=2.15.1&hash=da58a8"
dependencies:
classnames: "npm:^2.2.6"
lodash.debounce: "npm:^4.0.8"
lodash.memoize: "npm:^4.1.2"
lodash.reduce: "npm:^4.6.0"
lodash.startswith: "npm:^4.2.1"
prop-types: "npm:^15.7.2"
peerDependencies:
react: ^16.12.0 || ^17.0.0 || ^18.0.0 || ^19.0.0 || ^20.0.0 || ^21.0.0
react-dom: ^16.12.0 || ^17.0.0 || ^18.0.0 || ^19.0.0 || ^20.0.0 || ^21.0.0
checksum: 10c0/7822cfc665fb844f47d60b1c8848ad0b673e8b71b40d9edc6a72f8e33350b61033e63c2cadcc61367f2a47874c35014535154c2ae65df2284c0a79fe9e1914b9
languageName: node
linkType: hard

"react-popper@npm:^2.2.4, react-popper@npm:^2.2.5":
version: 2.3.0
resolution: "react-popper@npm:2.3.0"
Expand Down