Enable dynamic update of noise parameters in simpleNav during simulation #1061
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Yume27
force-pushed
the
feature/1047-enable-dynamic-update-of-noise-parameters-in-simplenav-during-simulation
branch
from
5a5b1c5 to
e7e6980
Compare
schaubh
changed the title
schaubh
requested changes
Aug 14, 2025
src/simulation/navigation/simpleNav/_UnitTest/test_simpleNav_noise.py
Outdated
Show resolved
Hide resolved
Yume27
force-pushed
the
feature/1047-enable-dynamic-update-of-noise-parameters-in-simplenav-during-simulation
branch
2 times, most recently
from
31a0674 to
1a4ccd4
Compare
Yume27
force-pushed
the
feature/1047-enable-dynamic-update-of-noise-parameters-in-simplenav-during-simulation
branch
from
1a4ccd4 to
cd9c44c
Compare
schaubh
approved these changes
Aug 26, 2025
Yume27
deleted the
feature/1047-enable-dynamic-update-of-noise-parameters-in-simplenav-during-simulation
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The random noise parameters (PMatrix and walkBounds) in the SimpleNav module were originally set only in the reset function, which prevented them from being changed during simulation. By enabling updates within the computeErrors function, these parameters can now be modified during runtime. This allows simulation of random noise changes caused by faults.
Verification
A unit test file (test_simpleNav_noise.py) was created to verify scaling the noise parameter values by a factor of 3, and all tests passed successfully.
Documentation
Updated the descriptions of PMatrix and walkBounds in simpleNav.h, and revised the release note.
Future work
N/A