-
Notifications
You must be signed in to change notification settings - Fork 82
Refactor GitHub workflows and use composite actions #1073
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor GitHub workflows and use composite actions #1073
Conversation
6362117
to
cc8c323
Compare
875e8e5
to
8b14def
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice refactor. Just a few comments and a question about including the one new python requirement to BSK requirements, rather than just including it in the CI test builds?
1b5888f
to
5c4b56b
Compare
In notice we have 10 "pending check" where the PR is waiting for the results for the old CI test run names. When this is pushed, I'll have to remember to edit the repo settings to look for these new test run names. Do you have GitHub access privileges to look into this yourself? Obviously not before this branch is pushed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
love this branch. I really like how you have refactors the CI scripts. Just some very minor items and questions about the commit history. You add some stuff in the first commit, only to un-add it in the 2nd commit. Should be easy to clean up.
Also, when pushed to develop, we'll need to change the GitHub repo settings to make the PR requirements look for these new CI test names.
5c4b56b
to
aaeae8d
Compare
aaeae8d
to
faf14e1
Compare
I don't believe so. I think the only GitHub settings privilege I have is to add new Repository secrets for actions. |
f8e01fc
to
9ef547c
Compare
Update GitHub Actions to build and test only the latest supported Python on Windows and Linux. On macOS, test all supported Python versions.
Astro constants should be imported from Basilisk.architecture.astroConstants. The duplicated values in src/utilities/astroFunctions.py have been deprecated for a year and are now removed.
9ef547c
to
9d0b878
Compare
Commit 985a42a was updated to add an extra macOS build with the |
Description
This PR aims to simplify and refactor our CI pipeline. By using GitHub actions we can have reusable components in the CI jobs that are easier to reason about and will be useful for automating the deployment of wheels in the future. The goals of this PR were to generally avoid changing CI behavior unless it removed duplication or increased consistency.
Notable changes
Verification
This PR will trigger workflows to validate the updates. Future commits may be added to resolve issues found during this testing. The PR should be squashed and merged to avoid polluting the git history.
Documentation
N/A
Future work
Evaluate which platforms to support, which Python versions to test on each, and whether to include Conan-based installs. This is out of scope for this PR, which focuses only on refactoring and simplifying the existing CI.
Update the CI to automatically create and deploy wheels to PyPI for all supported platforms. We currently build and store wheels for ubuntu but do not publish them.
Simplify the various requirements.txt files and move them into
pyproject.toml
per PEP 518 and PEP 621Closes #1072