-
Notifications
You must be signed in to change notification settings - Fork 23
Conditional beans include support in commons-spring #432
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghik
suggested changes
Mar 6, 2023
commons-spring/src/main/scala/com/avsystem/commons/spring/HoconBeanDefinitionReader.scala
Outdated
Show resolved
Hide resolved
commons-spring/src/test/scala/com/avsystem/commons/spring/HoconBeanDefinitionReaderTest.scala
Outdated
Show resolved
Hide resolved
commons-spring/src/main/scala/com/avsystem/commons/spring/HoconBeanDefinitionReader.scala
Outdated
Show resolved
Hide resolved
ghik
reviewed
Mar 6, 2023
commons-spring/src/main/scala/com/avsystem/commons/spring/HoconBeanDefinitionReader.scala
Outdated
Show resolved
Hide resolved
commons-spring/src/main/scala/com/avsystem/commons/spring/HoconBeanDefinitionReader.scala
Outdated
Show resolved
Hide resolved
commons-spring/src/main/scala/com/avsystem/commons/spring/HoconBeanDefinitionReader.scala
Outdated
Show resolved
Hide resolved
commons-spring/src/main/scala/com/avsystem/commons/spring/HoconBeanDefinitionReader.scala
Outdated
Show resolved
Hide resolved
ghik
approved these changes
Mar 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #431
Makes it possible to include some config only if specified feature flag is enabled. The position of the
conditionals
list in the file doesn't matter, it will always overwrite other definitions in the file if condition is true. The order of conditional objects in theconditionals
list does matter, the latter will possibly overwrite the former.