-
Notifications
You must be signed in to change notification settings - Fork 23
add lifecycle components #752
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
halotukozak
wants to merge
4
commits into
master
Choose a base branch
from
initializing-bean
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
54eb8e1
add lifecycle component traits and tests
halotukozak 3456a4c
refactor lifecycle components to improve initialization and disposal …
halotukozak 0dc7e68
fix analyzer and lifecycle component tests: adjust type annotation an…
halotukozak 009d7b6
add documentation for lifecycle-aware components with initialization …
halotukozak File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
91 changes: 91 additions & 0 deletions
91
core/jvm/src/test/scala/com/avsystem/commons/di/LifeCycleComponentTest.scala
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,91 @@ | ||
package com.avsystem.commons | ||
package di | ||
|
||
import monix.execution.atomic.{Atomic, AtomicInt} | ||
import org.scalatest.funsuite.AsyncFunSuite | ||
|
||
final class LifeCycleComponentTest extends AsyncFunSuite with Components { | ||
|
||
object init { | ||
val inits: AtomicInt = Atomic(0) | ||
val component: Component[InitializingComponent] = singleton { | ||
new InitializingComponent { | ||
override def init(): Unit = inits += 1 | ||
} | ||
} | ||
} | ||
|
||
object asyncInit { | ||
val inits: AtomicInt = Atomic(0) | ||
val component: Component[AsyncInitializingComponent] = singleton { | ||
new AsyncInitializingComponent { | ||
def init()(implicit ec: ExecutionContext): Future[Unit] = Future { | ||
inits += 1 | ||
}(ec) | ||
} | ||
} | ||
} | ||
|
||
object disposable { | ||
val destroys: AtomicInt = Atomic(0) | ||
val component: Component[DisposableComponent] = singleton { | ||
new DisposableComponent { | ||
def destroy(): Unit = destroys += 1 | ||
} | ||
} | ||
} | ||
|
||
|
||
object asyncDisposable { | ||
val destroys: AtomicInt = Atomic(0) | ||
val component: Component[AsyncDisposableComponent] = singleton { | ||
new AsyncDisposableComponent { | ||
def destroy()(implicit ec: ExecutionContext): Future[Unit] = Future { | ||
destroys += 1 | ||
}(using ec) | ||
} | ||
} | ||
} | ||
|
||
test("InitializingComponent singleton initializes once and returns same instance")(for { | ||
_ <- Future.unit | ||
_ = assert(init.inits.get() == 0) | ||
c1 <- init.component.init | ||
_ = assert(init.inits.get() == 1) | ||
c2 <- init.component.init | ||
_ = assert(init.inits.get() == 1) | ||
} yield assert(c1 eq c2)) | ||
|
||
test("AsyncInitializingComponent singleton initializes once and returns same instance")(for { | ||
_ <- Future.unit | ||
_ = assert(asyncInit.inits.get() == 0) | ||
c1 <- asyncInit.component.init | ||
_ = assert(asyncInit.inits.get() == 1) | ||
c2 <- asyncInit.component.init | ||
_ = assert(asyncInit.inits.get() == 1) | ||
} yield assert(c1 eq c2)) | ||
|
||
test("DisposableComponent destroy triggers side effect")(for { | ||
_ <- Future.unit | ||
_ <- disposable.component.destroy | ||
_ = assert(disposable.destroys.get() == 0) | ||
_ <- disposable.component.init | ||
_ = assert(disposable.destroys.get() == 0) | ||
_ <- disposable.component.destroy | ||
_ = assert(disposable.destroys.get() == 1) | ||
_ <- disposable.component.destroy | ||
_ = assert(disposable.destroys.get() == 1) | ||
} yield succeed) | ||
|
||
test("AsyncDisposableComponent destroy triggers side effect")(for { | ||
_ <- Future.unit | ||
_ <- asyncDisposable.component.destroy | ||
_ = assert(asyncDisposable.destroys.get() == 0) | ||
_ <- asyncDisposable.component.init | ||
_ = assert(asyncDisposable.destroys.get() == 0) | ||
_ <- asyncDisposable.component.destroy | ||
_ = assert(asyncDisposable.destroys.get() == 1) | ||
_ <- asyncDisposable.component.destroy | ||
_ = assert(asyncDisposable.destroys.get() == 1) | ||
} yield succeed) | ||
} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
18 changes: 18 additions & 0 deletions
18
core/src/main/scala/com/avsystem/commons/di/LifeCycleComponents.scala
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,18 @@ | ||
package com.avsystem.commons | ||
package di | ||
|
||
trait InitializingComponent { | ||
def init(): Unit | ||
} | ||
|
||
trait DisposableComponent { | ||
def destroy(): Unit | ||
} | ||
|
||
trait AsyncInitializingComponent { | ||
def init()(implicit ec: ExecutionContext): Future[Unit] | ||
} | ||
|
||
trait AsyncDisposableComponent { | ||
def destroy()(implicit ec: ExecutionContext): Future[Unit] | ||
} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A simple
.flatMap { value => value match {
with mappings tovalue
allows to avoid casting here.