Skip to content

CI build inconsistency #20

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
AXeL-dev opened this issue Feb 4, 2021 · 3 comments
Closed

CI build inconsistency #20

AXeL-dev opened this issue Feb 4, 2021 · 3 comments
Labels

Comments

@AXeL-dev
Copy link
Owner

AXeL-dev commented Feb 4, 2021

Some artifacts on CI build weirdly doesn't match with manually built artifacts (& more exactly the static/*.chunk.js file).

You can use a tool like Meld to do the comparison (keep in mind that you might need to unminify minified js files to get readable/viewable results).

#needs_deep_investigation

AXeL-dev added a commit that referenced this issue Feb 4, 2021
AXeL-dev added a commit that referenced this issue Feb 6, 2021
was importing some useless libraries on build (due to misconfiguration on bcrypt import)
AXeL-dev added a commit that referenced this issue Feb 6, 2021
Related to  #20
@AXeL-dev
Copy link
Owner Author

AXeL-dev commented Feb 6, 2021

bcrypt js issue seems to be fixed + bundle size reduced, but the static/*.chunk.js file still contains different bundled code from the one built on local env. (which makes no sense for now.. so, does a dependency includes/injects different code depending on the environment?)

AXeL-dev added a commit that referenced this issue Feb 6, 2021
@AXeL-dev
Copy link
Owner Author

AXeL-dev commented Feb 6, 2021

it seems like this issue might be related to webpack 🤔 .

Edit:

Also check:

Hash issue seems to be fixed on webpack 5 (still need to wait for an official support of this version from the create react app team).

AXeL-dev added a commit that referenced this issue Feb 14, 2021
AXeL-dev added a commit that referenced this issue Feb 14, 2021
+ Disabled source map files generation (because generated paths inside map files may differ depending on build location which cause build artifacts to be different)
@AXeL-dev
Copy link
Owner Author

AXeL-dev commented Feb 14, 2021

Stills those different files on build artifacts (see the screenshot):

image

The most of file diffs seems to be related to evergreen-ui core components, so we might need to upgrade evergreen to next 6.x version once it get released. (or to open an issue on their repo & ask for help 👀)

@AXeL-dev AXeL-dev added wontfix This will not be worked on and removed to investigate labels Jun 26, 2021
@stale stale bot removed the wontfix This will not be worked on label Jun 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant