#532 - Add code coverage support - Jacoco #533
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- added new plugin dependency - extended readme.md file with how to get code coverage report - extended build logic to add JaCoCo non-default settings
|
After this is merged we can remove |
yruslan
approved these changes
Nov 21, 2022
Zejnilovic
reviewed
Nov 21, 2022
Comment on lines
+1436
to
+1444
| ### How to generate Code coverage report | ||
| ```sbt | ||
| sbt jacoco | ||
| ``` | ||
| Code coverage will be generated on path: | ||
| ``` | ||
| {local-path}\fixed-width\target\scala-2.XY\jacoco\report\html | ||
| ``` | ||
|
|
There was a problem hiding this comment.
Yes, I was in doubt if it even needed to place in readme when I saw that file. Remove it?
It depends. You are used to use it. So now we can compare additional value of both. |
|
Happy to leave scoverage for now. I'd ask a small thing. Please, use Rebase&Merge when you are ready. We use 'Create Merge Commit' only for artifact releases to ensure the commit is signed and matches 100% the artifact. Rebasing is the way to go for other changes. |
miroslavpojer
deleted the
feature/532-add-code-coverage-support-jacoco
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #532