#11 Add support for enums without renaming #24
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JaCoCo code coverage report - springdoc-openapi-scala
|
TheLydonKing
approved these changes
Jan 2, 2024
| @@ -66,6 +67,7 @@ class OpenAPIModelRegistration(components: Components) { | |||
| case t if t <:< typeOf[Option[_]] => handleType(t.typeArgs.head) | |||
| case t if t <:< typeOf[Seq[_]] || t <:< typeOf[Array[_]] => handleSeqLike(t) | |||
| case t if t <:< typeOf[Set[_]] => handleSet(t) | |||
| case t if t <:< typeOf[Enumeration#Value] => handleEnum(tpe) | |||
There was a problem hiding this comment.
Why do you pass tpe here and not t?
There was a problem hiding this comment.
Actually can be t. Changed, thanks.
Initially when I was experimenting, I passed tpe as it is not dealiased, and I thought it might be needed non-dealiased. But parentObjectType is fortunately the same whether dealiased or not, so can be t.
| assertEnumIsStringAndHasFollowingOptions(actualSchemas, "SimpleEnums.b", Set("Cleaner", "Floor")) | ||
| } | ||
|
|
||
| it should "make complex Enumeration (with renaming) an OpenAPI enum" ignore { // TODO: #23 |
There was a problem hiding this comment.
This test is ignored as it currently doesn't pass (this PR adds support only for simple Enumerations). Changed the comment to be more descriptive
kevinwallimann
approved these changes
Jan 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #11