-
Notifications
You must be signed in to change notification settings - Fork 0
#26 Implement ExtraTypesHandler which enables adding custom types support by clients #32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
jakipatryk
merged 8 commits into
main
from
feature/26-make-it-possible-for-clients-to-support-custom-types
Jan 11, 2024
Merged
#26 Implement ExtraTypesHandler which enables adding custom types support by clients #32
jakipatryk
merged 8 commits into
main
from
feature/26-make-it-possible-for-clients-to-support-custom-types
Jan 11, 2024
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…clients to handle their custom types
…ssible-for-clients-to-support-custom-types # Conflicts: # library/src/main/scala/za/co/absa/springdocopenapiscala/Bundle.scala # library/src/main/scala/za/co/absa/springdocopenapiscala/OpenAPIModelRegistration.scala # library/src/test/scala/za/co/absa/springdocopenapiscala/OpenAPIModelRegistrationSpec.scala
JaCoCo code coverage report - springdoc-openapi-scala-1
|
JaCoCo code coverage report - springdoc-openapi-scala-2
|
…ssible-for-clients-to-support-custom-types
dk1844
previously approved these changes
Jan 10, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM (just read the code)
library/src/main/scala/za/co/absa/springdocopenapiscala/OpenAPIModelRegistration.scala
Outdated
Show resolved
Hide resolved
Co-authored-by: Daniel K <[email protected]>
dk1844
approved these changes
Jan 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part 1 of #26. Part 2 will be in another PR.
ExtraTypesHandler
, which is aPartialFunction
used to add support for any type the library user needs (with higher precedence than the library types handling)