Skip to content

#26 Implement ExtraTypesHandler which enables adding custom types support by clients #32

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

jakipatryk
Copy link
Collaborator

@jakipatryk jakipatryk commented Jan 10, 2024

Part 1 of #26. Part 2 will be in another PR.

  • introduced ExtraTypesHandler, which is a PartialFunction used to add support for any type the library user needs (with higher precedence than the library types handling)

…ssible-for-clients-to-support-custom-types

# Conflicts:
#	library/src/main/scala/za/co/absa/springdocopenapiscala/Bundle.scala
#	library/src/main/scala/za/co/absa/springdocopenapiscala/OpenAPIModelRegistration.scala
#	library/src/test/scala/za/co/absa/springdocopenapiscala/OpenAPIModelRegistrationSpec.scala
Copy link

github-actions bot commented Jan 10, 2024

JaCoCo code coverage report - springdoc-openapi-scala-1

Overall Project 95.57% -6.64% 🍏
Files changed 87.35% 🍏

File Coverage
OpenAPIModelRegistration.scala 97.41% -5.54% 🍏
Bundle.scala 0% -66.67%

Copy link

github-actions bot commented Jan 10, 2024

JaCoCo code coverage report - springdoc-openapi-scala-2

Overall Project 95.57% -6.64% 🍏
Files changed 87.35% 🍏

File Coverage
OpenAPIModelRegistration.scala 97.41% -5.54% 🍏
Bundle.scala 0% -66.67%

@jakipatryk jakipatryk marked this pull request as ready for review January 10, 2024 15:03
dk1844
dk1844 previously approved these changes Jan 10, 2024
Copy link

@dk1844 dk1844 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (just read the code)

@jakipatryk jakipatryk merged commit 83a862e into main Jan 11, 2024
@jakipatryk jakipatryk deleted the feature/26-make-it-possible-for-clients-to-support-custom-types branch January 11, 2024 13:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants