simplify core API #178
Merged
simplify core API #178
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Anton Dukhovnikov <[email protected]>
soswow
reviewed
Sep 2, 2025
include/rawtoaces/rawtoaces_core.h
Outdated
| /// The constructor. Takes the database search path as an optional | ||
| /// parameter. | ||
| /// @param search_path optional database search path. | ||
| SpectralSolver( const std::vector<std::string> &search_path = {} ); |
There was a problem hiding this comment.
Can we make it search_paths since it's a list of things?
There was a problem hiding this comment.
tricky, I'd rather call it search_directories then. usually $PATH is singular, but contains multiple locations
soswow
reviewed
Sep 2, 2025
|
|
||
| SpectralSolver::SpectralSolver() | ||
| SpectralSolver::SpectralSolver( const std::vector<std::string> &search_path ) | ||
| : _search_path( search_path ) |
There was a problem hiding this comment.
don't forget about this one to be _search_paths as well if you happy with above suggestion
soswow
reviewed
Sep 2, 2025
| std::filesystem::path type_path( directory ); | ||
| type_path.append( type ); | ||
| if ( std::filesystem::exists( type_path ) ) | ||
| { |
There was a problem hiding this comment.
do we care to warn about something in else case of this and previous if?
soswow
reviewed
Sep 2, 2025
Signed-off-by: Anton Dukhovnikov <[email protected]>
Signed-off-by: Anton Dukhovnikov <[email protected]>
soswow
approved these changes
Sep 2, 2025
Co-authored-by: Aleksandr Motsjonov <[email protected]> Signed-off-by: Anton Dukhovnikov <[email protected]>
antond-weta
merged commit 7b3a170
into
AcademySoftwareFoundation:master
13 checks passed
mangopep
pushed a commit
to mangopep/rawtoaces
that referenced
this pull request
Sep 10, 2025
* simplify core API Signed-off-by: Anton Dukhovnikov <[email protected]> * address review issues Signed-off-by: Anton Dukhovnikov <[email protected]> * address review issues Signed-off-by: Anton Dukhovnikov <[email protected]> * Update src/rawtoaces_core/rawtoaces_core.cpp Co-authored-by: Aleksandr Motsjonov <[email protected]> Signed-off-by: Anton Dukhovnikov <[email protected]> --------- Signed-off-by: Anton Dukhovnikov <[email protected]> Co-authored-by: Aleksandr Motsjonov <[email protected]> Signed-off-by: Savitha M <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.