Test coverage report with badge and logo #188
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Welcome to Codecov 🎉Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests. Thanks for integrating Codecov - We've got you covered ☂️ |
soswow
force-pushed
the
test-coverage
branch
from
e44b95b to
e36dc98
Compare
soswow
commented
Sep 7, 2025
soswow
commented
Sep 7, 2025
| COMMAND ${CMAKE_COMMAND} -E echo "Coverage report generated in ${CMAKE_BINARY_DIR}/coverage/html/index.html" | ||
| WORKING_DIRECTORY ${CMAKE_BINARY_DIR} | ||
| COMMENT "Generating code coverage report" | ||
| ) |
There was a problem hiding this comment.
This section is a bit of a black magic for me and I can't claim I understand exactly what's going on here. I prob. should figure it out and know better.
soswow
commented
Sep 7, 2025
| if( ENABLE_COVERAGE AND COVERAGE_SUPPORTED ) | ||
| # Include config_tests subdirectories | ||
| add_subdirectory(config_tests/core) | ||
| add_subdirectory(config_tests/util) |
There was a problem hiding this comment.
this basically makes sure that congi_tests are run as part of coverage. So if something is only through these tests should technically add coverage. Thought enabling disabling them I didn't see change in coverage.
soswow
commented
Sep 7, 2025
| { | ||
| pathToRaw = std::filesystem::absolute( "../../../.." + image_path ); | ||
| } | ||
|
|
There was a problem hiding this comment.
this needed for test to run in two modes
soswow
commented
Sep 7, 2025
| // Only run on the linux CI runners. | ||
| #ifdef __LINUX__ | ||
| // Run on Linux CI and macOS runners | ||
| #if defined( __LINUX__ ) || defined( __APPLE__ ) |
There was a problem hiding this comment.
so I guess it works now 🤷
antond-weta
approved these changes
Sep 8, 2025
Signed-off-by: Aleksandr Motsjonov <[email protected]>
Signed-off-by: Aleksandr Motsjonov <[email protected]>
Signed-off-by: Aleksandr Motsjonov <[email protected]>
Signed-off-by: Aleksandr Motsjonov <[email protected]>
Signed-off-by: Aleksandr Motsjonov <[email protected]>
Signed-off-by: Aleksandr Motsjonov <[email protected]>
antond-weta
force-pushed
the
test-coverage
branch
from
a908048 to
daac863
Compare
mangopep
pushed a commit
to mangopep/rawtoaces
that referenced
this pull request
Sep 10, 2025
* test ci Signed-off-by: Aleksandr Motsjonov <[email protected]> * clang formatting Signed-off-by: Aleksandr Motsjonov <[email protected]> * Check if it might just work Signed-off-by: Aleksandr Motsjonov <[email protected]> * formatting Signed-off-by: Aleksandr Motsjonov <[email protected]> * Revert the revert Signed-off-by: Aleksandr Motsjonov <[email protected]> * revert the enabling Signed-off-by: Aleksandr Motsjonov <[email protected]> --------- Signed-off-by: Aleksandr Motsjonov <[email protected]> Signed-off-by: Savitha M <[email protected]>
mikaelsundell
pushed a commit
to mikaelsundell/rawtoaces
that referenced
this pull request
Sep 11, 2025
* test ci Signed-off-by: Aleksandr Motsjonov <[email protected]> * clang formatting Signed-off-by: Aleksandr Motsjonov <[email protected]> * Check if it might just work Signed-off-by: Aleksandr Motsjonov <[email protected]> * formatting Signed-off-by: Aleksandr Motsjonov <[email protected]> * Revert the revert Signed-off-by: Aleksandr Motsjonov <[email protected]> * revert the enabling Signed-off-by: Aleksandr Motsjonov <[email protected]> --------- Signed-off-by: Aleksandr Motsjonov <[email protected]> Signed-off-by: Mikael Sundell <[email protected]>
mikaelsundell
pushed a commit
to mikaelsundell/rawtoaces
that referenced
this pull request
Sep 12, 2025
* test ci Signed-off-by: Aleksandr Motsjonov <[email protected]> * clang formatting Signed-off-by: Aleksandr Motsjonov <[email protected]> * Check if it might just work Signed-off-by: Aleksandr Motsjonov <[email protected]> * formatting Signed-off-by: Aleksandr Motsjonov <[email protected]> * Revert the revert Signed-off-by: Aleksandr Motsjonov <[email protected]> * revert the enabling Signed-off-by: Aleksandr Motsjonov <[email protected]> --------- Signed-off-by: Aleksandr Motsjonov <[email protected]> Signed-off-by: Mikael Sundell <[email protected]>
mikaelsundell
pushed a commit
to mikaelsundell/rawtoaces
that referenced
this pull request
Sep 14, 2025
* test ci Signed-off-by: Aleksandr Motsjonov <[email protected]> * clang formatting Signed-off-by: Aleksandr Motsjonov <[email protected]> * Check if it might just work Signed-off-by: Aleksandr Motsjonov <[email protected]> * formatting Signed-off-by: Aleksandr Motsjonov <[email protected]> * Revert the revert Signed-off-by: Aleksandr Motsjonov <[email protected]> * revert the enabling Signed-off-by: Aleksandr Motsjonov <[email protected]> --------- Signed-off-by: Aleksandr Motsjonov <[email protected]> Signed-off-by: Mikael Sundell <[email protected]>
antond-weta
pushed a commit
to mikaelsundell/rawtoaces
that referenced
this pull request
Sep 17, 2025
* test ci Signed-off-by: Aleksandr Motsjonov <[email protected]> * clang formatting Signed-off-by: Aleksandr Motsjonov <[email protected]> * Check if it might just work Signed-off-by: Aleksandr Motsjonov <[email protected]> * formatting Signed-off-by: Aleksandr Motsjonov <[email protected]> * Revert the revert Signed-off-by: Aleksandr Motsjonov <[email protected]> * revert the enabling Signed-off-by: Aleksandr Motsjonov <[email protected]> --------- Signed-off-by: Aleksandr Motsjonov <[email protected]> Signed-off-by: Mikael Sundell <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.