subshell.DetectShell should default to zsh on macOS. #3672
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mitchell-as
force-pushed
the
mitchell/dx-3248
branch
2 times, most recently
from
0551caf to
e8c1f4d
Compare
…er command. When running the one-line installer, it executes in sh, which is most likely not the user's actual shell.
mitchell-as
force-pushed
the
mitchell/dx-3248
branch
from
e8c1f4d to
f40c04f
Compare
tjsanterre
approved these changes
Apr 16, 2025
as-builds
added a commit
that referenced
this pull request
Apr 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: this only happens when invoking the one-liner. Running ./install.sh by itself doesn't trigger this.
Also, I had to update Go to address a CVE or else this PR's checks would not pass.