Skip to content
This repository was archived by the owner on Jul 24, 2023. It is now read-only.

Conversation

harrygulliford
Copy link
Contributor

As of Laravel 5.8, the Event::fire method has been officially removed and replaced with Event::dispatch.

https://laravel.com/docs/5.8/upgrade#events

This PR adds support for Laravel 5.8, however will mean the minimum supported version will now be 5.4+

If keeping 5.0-5.3 support is imperative, it may be possible to create a function to delegate between Event::fire and Event::dispatch based upon the value returned from App::version().

@stevebauman
Copy link
Member

Thanks @harrygulliford!

Maybe the event() helper might be better used to support all versions of 5.X? Thoughts?

@harrygulliford
Copy link
Contributor Author

@stevebauman Agreed! The event() helper definitely looks like the best option here.

@stevebauman
Copy link
Member

Perfect thanks again! Are you possibly able to add the setUp(): void return type declaration for the tests to pass? I’m not at a computer at the moment unfortunately.

@stevebauman
Copy link
Member

Whoops that was quick! Thanks! 😄

@harrygulliford
Copy link
Contributor Author

All green! ✅

@stevebauman stevebauman merged commit b3f5c53 into Adldap2:master Feb 27, 2019
stevebauman pushed a commit that referenced this pull request Mar 2, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants