Skip to content

Added RightClick option to config #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Added RightClick option to config #1

wants to merge 1 commit into from

Conversation

AlexVvx
Copy link
Owner

@AlexVvx AlexVvx commented Oct 10, 2017

Related to #248

This PR adds rightClick config attribute. The purpose of new attribute is to let users use their own context menu instead of browser context menu.

RightClick is boolean:

  • true nothing changed
  • false - default browser context menu disabled, 'contextmenu' event fired on element.

…hen equal false - default browser context menu disabled, 'contextmenu' event fired on element
@alexcjohnson
Copy link
Collaborator

@AlexVvx thanks for the PR! But see plotly#248 (comment) - I really think we should try to solve this without having to add an extra config option. If we explore that strategy and conclude it won't work, then this looks like a good backup plan.

@AlexVvx AlexVvx closed this Oct 12, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants