Check if not a left-click, then bail out of onStart #2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| var rightclick; | ||
| if(e.which) { rightclick = (e.which === 3); } | ||
| else if(e.button) { rightclick = (e.button === 2); } |
There was a problem hiding this comment.
Ah nice, I was initially thinking of testing for "not a left click" but this is better - more robust and targeted.
It doesn't look like we actually need e.which anymore - far as I can tell every browser modern enough to support SVG defines e.button.
We'll need to include a test or two of this behavior, probably in https://github.com/plotly/plotly.js/blob/master/test/jasmine/tests/dragelement_test.js - want to give that a try and PR it to the main repo?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #248
This PR adds check in dragElement. On start, if not a left-click, then bail out of onStart. The purpose of this check is to let developers to use their own context menu instead of browser context menu. Without that check there were no possibility to see 'contextmenu' event when click inside plot container.