bootstrap.js dependency

[frontsideair]

I noticed that we need bootstrap.js as a global runtime dependency as the pagination size dropdown functionality depends on a data-toggle property which is provided by Bootstrap JS code. I'm considering moving that functionality to React as a way to remove this global dependency.

If there is anyplace else using bootstrap.js that you can point out, I'll keep that in mind when doing that.

[AllenFang]

@frontsideair, thanks for this issue report, I almost forgot that we need bootstrap.js as a global dependency. As far as I know, this dependency is just only for pagination size dropdown.

Anyway, how do you add bootstrap dependency, use npm? or any idea to solve this problem

[frontsideair]

At first I just included it in the HTML with a <script> tag, but then I realized since I use webpack's code splitting feature to emit an app.js and a vendor.js, I added bootstrap to vendor array and it just worked.

Anyway, if it's only used for the dropdown, it'll be easy and totally worth it to implement it with React.

[AllenFang]

👍 so is it a good idea to bundle bootstrap.js to react-bootstrap-table in your opinion?(It's just a question)

[frontsideair]

Today I was trying to remove jQuery dependency from our stack and stumbled upon this. I'll probably take some time tomorrow to implement dropdown functionality with React and send a PR. If I can't, we'll need to bundle bootstrap.js and jquery.js for everything to work correctly until this is done. :(

[frontsideair]

@AllenFang I started working on implementing pagination dropdown functionality with React, but I need some way to handle clicking outside the dropdown to close it. react-onclickoutside worked great for me, is it okay to add it as a dependency? Or do you suggest something else?

[staminaloops]

https://github.com/Pomax/react-onclickoutside/blob/master/decorator.js is so little, I think its way better than jquery + bootstrap.js (my opinion ofc 👍 )

[AllenFang]

@frontsideair @staminaloops, I accept your suggestion, it's a good idea 👍

[CrisLi]

Why revert the commit?

[AllenFang]

@CrisLi, #232 (comment)

[AllenFang]

Because there's something missing, so still need to fix. Hope I can solve this in the near future, so just reopen it

[frontsideair]

Sorry, I was supposed to do this but life's been hectic lately so I couldn't make time to do it.

[AllenFang]

@frontsideair, that's fine, I'll do it :)

[Gennon]

You probably don't want the to have the react-bootstrap dependencies, but at least they have a great dropdown that could help solving this issue? https://react-bootstrap.github.io/components.html#btn-dropdowns

https://github.com/react-bootstrap/react-bootstrap/blob/master/src/Dropdown.js

I don't know about most other users, but I use react-bootstrap with my react-bootstrap-table, so having a dependency on react-bootstrap would not have any implications for me. Keep up the good work!

[AllenFang]

@Gennon, thanks sharing, I've planned to tackle this issue on v3.0.0. hope we can solve this critical issue !

[patrickgordon]

It would be great to have this depend on on react-bootstrap or some other solution. Great library, keep up the good work, hope to see a solution for this sometime soon!

[AllenFang]

HI @patrickgordon, you can check #497, I've planned to remove it in the future, hope I can solve this dependency issue.
Thanks :)