-
Notifications
You must be signed in to change notification settings - Fork 775
Performance issues? #695
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Um. Just wanted to let you know this issue gets quite massive when you have a decent table. e.g. mine has like 10 columns with 3 dates and when I want to show more than 10 rows it gets quite laggy. |
@Obiwarn, yap, there's actually a known performance issue. I'll try to fix it. But really need some time.. Sorry, I'm also busy on my work. So PR is welcome. |
By fixing it, are you talking about implementing virtual rendering? Because that would be awesome in many levels. It's the last thing this needs to totally overshadow other static table libraries. |
@AllenFang indeed. I reviewed all popular table libs and yours is just fantastic and has such great code samples. |
I'd have to agree with others here. This is by far the best table component I've used. 👏 |
@AllenFang i implemented lazy loading (#26, #557) for this table, which should fix the performance issue. I can provide a PR, but this will take some time since i have a lot to do at work. |
@oeph, that's ok, PR is welcome :) |
@oeph any progress in terms of lazy loading? I'm thinking of implementing it but don't want to duplicate the work |
@kzbikowski i have it done. i will merge on current branch and make a PR. not sure tho on the exact time |
Hi @oeph , did your implementation of infinite scroll get merged in? I am super keen to get infinite scroll working on the table. Thanks. Simon |
since the lazy loading was implemented last year nov. there are major changes within the component itself. I'm working on the solution in the current version without breaking the current API, but for now i would suggest to use the method described in #1133 or use react-virtualized for example. since i'm busy at work i can't make any promises when i will have this finished |
Hi just wanted to ask if lazy loading/virtualization is still being actively worked on? If not, in the above comment it @oeph mentions using this library with react-virtualized. Wondering if anyone could provide a simple example of how that would work. Thanks for this great library! |
I'm having a lot of issues too with table load time. I have basically two tables on screen, one hidden, then when a user hits a tab, that table is then displayed. I'd be happy to do something more like div display:block vs. none to quickly show/hide it but doesn't seem obvious how I do this in React, so each tab toggle requires a real-time redraw... |
@JohnVLinton To me that sounds more like a problem with the tab component. It could just render the selected tab instead of rendering both and using display:none; Since react-bootstrap-table is not actively worked on anymore, you should maybe look at https://github.com/react-bootstrap-table/react-bootstrap-table2 |
This is a minor issue but when I do a reactive search in my table, Griddle felt a lot snappier than this table (I guess it could have to do with column resizing?). Maybe there is room for performance improvements (e.g. fixed widths or sth.)?
The text was updated successfully, but these errors were encountered: