lots of linting #518
lots of linting #518
Conversation
I think I have found all of the places where we pass the format kwarg to pandas.read_hdf(), which is not allowed anymore by new versions of pandas. This also removes commented-out lines that I had left in an earlier commit.
There was a problem hiding this comment.
I think this is the right place to have the linting fixes. I was being paranoid earlier. I also had the dream of including more linting fixes in this PR, to try and get the tests working again, but there would be some fixes required beyond just adding whitespace, etc. So I think we should just do these commits together.
|
This addresses issue #513 and makes PR #514 unnecessary. For future reference, here's the explanation for the #513 fix: This PR addresses issue #513 by changing all of the calls to pandas.read_hdf() to no longer pass 'format' as a kwarg. We used to do this, and the passed kwarg was ignored by HDFStore.open because it wasn't a defined keyword arg for that method, but no alarms were raised. In newer versions of pandas there is an exception raised if you try to pass 'format' to the read_hdf() method. Removing this kwarg:
|
No description provided.