ensure dot in zone:id

[splashx]

Closes #380

[CapsuleCD]

Hi.

I'm an automated pull request bot named CapsuleCD. I handle testing, versioning and package releases for this project.

• If you're the owner of this repo, you can click the button below to kick off the CapsuleCD build pipeline and create an automated release.'
• If not, don't worry, someone will be by shortly to check on your pull request.

---

If you're interested in learning more about CapsuleCD, or adding it to your project, you can check it out here

[splashx]

I want to point out this is passing, the problem is with pylint+tox causing all sort of problems :(
Increasing the version of pylint will create a bunch of false positives for R0801 (see pylint-dev/pylint#1055 - which actually didnt solve the problem)

[adferrand]

Hello @splashx, I fixed the pylint errors, you should be able to fix your PR tests with a merge from master.

[splashx]

@adferrand done. Please review the AppVeyor CI part as I think it's not related to these changes.

[AnalogJ]

Hey @splashx Thanks for the PR!
Would the _fqdn_name helper do the same thing that you're trying to do?

https://github.com/AnalogJ/lexicon/blob/master/lexicon/providers/base.py#L153

[splashx]

@AnalogJ not really. PowerDNS expects the zone:id (not the fqdn) in a dot-format.
I also didn’t want to plumb this at a higher level and change self.domain because that breaks some logics. So I think this is the appropriate place for this.
Currently those using lexicon and dealing with PowerDNS must write their own “ensure dot” function and pass that for every zone-handling action. It’s tedious.

[AnalogJ]

LGTM. Thanks for the PR @splashx 🎉