Skip to content

Conversation

AnXh3L0
Copy link
Contributor

@AnXh3L0 AnXh3L0 commented Jul 4, 2022

This PR fixes extra spacing/layouting for the cards inside individual documentation pages.

Before
image

After
image

AnXh3L0 added 2 commits July 4, 2022 22:34
This uses the jekyll-github-metadata gem and pulls the data from the GitHub API (it would need a periodic automated rebuild of the site in order to get the latest data; I would suggest daily). The content is then cached and does no 3rd party calls.
@AnXh3L0
Copy link
Contributor Author

AnXh3L0 commented Jul 4, 2022

The second commit adds an initial version of the code that pulls the latest release number, and the latest changelog. The layout of this is only a draft and it can be improved upon. Additionally, more data can be pulled automatically so we can make a big part of the site "dynamic". I would like to hear your thoughts @ByteHamster @keunes and anyone else :)
https://user-images.githubusercontent.com/25004151/177218804-8fe28dca-dc74-4bce-8002-15ea93982749.mp4

@AnXh3L0 AnXh3L0 marked this pull request as draft July 4, 2022 21:45
@ByteHamster
Copy link
Member

This PR fixes extra spacing/layouting for the cards inside individual documentation pages.

Thanks, looks good. Next time, please create a new PR for each feature, so that the features can be merged+reviewed individually. I would already merge that first commit but have some comments about the second one.

The second commit adds an initial version of the code that pulls the latest release number

I think I would move it below the download button. Having it above the main website text is a bit too prominent. I have two style ideas:

  • I would try adding a light gray background below the expanded changelog
  • I would remove the padding between the blue and the gray box, so that there is a single box with two colors instead of two boxes within each other

@keunes
Copy link
Member

keunes commented Jul 17, 2022

Hi @AnXh3L0,

Welcome back! :) I would love merge already the documentation cards improvement, while allowing some more time for tweaks to the 'latest release' feature (which looks quite cool already!).

Could we somehow still split the two?

Cheers

@AnXh3L0
Copy link
Contributor Author

AnXh3L0 commented Jul 18, 2022

Hey @keunes,

Thanks :D Sure, I believe we can split the two, and then make another PR for the latest release feature.

@keunes
Copy link
Member

keunes commented Jul 24, 2022

@AnXh3L0 Would you mind doing the split? I don't know how to do it properly (via git). I could take & apply your changes in another PR, but then you wouldn't be the git author :)

@AnXh3L0
Copy link
Contributor Author

AnXh3L0 commented Jul 25, 2022

@keunes sure, I'll try to deal with it this evening.

@AnXh3L0 AnXh3L0 marked this pull request as ready for review July 27, 2022 07:52
@AnXh3L0
Copy link
Contributor Author

AnXh3L0 commented Jul 27, 2022

@keunes @ByteHamster you can merge this PR and squash the commits. I will then work on the GitHub-related changes on a new branch and open another PR.

@keunes keunes merged commit 795067c into AntennaPod:master Jul 28, 2022
@keunes
Copy link
Member

keunes commented Jul 28, 2022

Thanks @AnXh3L0!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants