-
Notifications
You must be signed in to change notification settings - Fork 25
Fix layout for inner documentation cards #163
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This uses the jekyll-github-metadata gem and pulls the data from the GitHub API (it would need a periodic automated rebuild of the site in order to get the latest data; I would suggest daily). The content is then cached and does no 3rd party calls.
The second commit adds an initial version of the code that pulls the latest release number, and the latest changelog. The layout of this is only a draft and it can be improved upon. Additionally, more data can be pulled automatically so we can make a big part of the site "dynamic". I would like to hear your thoughts @ByteHamster @keunes and anyone else :) |
Thanks, looks good. Next time, please create a new PR for each feature, so that the features can be merged+reviewed individually. I would already merge that first commit but have some comments about the second one.
I think I would move it below the download button. Having it above the main website text is a bit too prominent. I have two style ideas:
|
Hi @AnXh3L0, Welcome back! :) I would love merge already the documentation cards improvement, while allowing some more time for tweaks to the 'latest release' feature (which looks quite cool already!). Could we somehow still split the two? Cheers |
Hey @keunes, Thanks :D Sure, I believe we can split the two, and then make another PR for the latest release feature. |
@AnXh3L0 Would you mind doing the split? I don't know how to do it properly (via git). I could take & apply your changes in another PR, but then you wouldn't be the git author :) |
@keunes sure, I'll try to deal with it this evening. |
@keunes @ByteHamster you can merge this PR and squash the commits. I will then work on the GitHub-related changes on a new branch and open another PR. |
Thanks @AnXh3L0! |
This PR fixes extra spacing/layouting for the cards inside individual documentation pages.
Before

After
