-
Notifications
You must be signed in to change notification settings - Fork 25
Improve open in AP page #439
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Thanks for starting this!
We don't need a script I think. We could just showcase code, something like this (maybe check/improve with AI).
Myeah. I also noticed on mobile that 'select all' selects the whole page. Maybe it'd be nice to prevent that if possible also. This is relevant if this page is shared on social media and someone has another podcast app. I can look into this when I'm back from holidays. And two other points: seeing the page I would
And we need to fix this:
|
These 3 points are addressed. Looking at the latest preview, I wonder if the third screenshot is necessary at all - perhaps the example link is sufficiently illustrative and we can shorten the page? The style issue is logged in #438. |
Yeah, that's probably fine. FMI: |
Are we allowed to use the logo of that podcast in the screenshot? (Do we need to have permission?) |
I doubt they would object, but I haven't reached out. If we already have permission from the other podcasts we feature in our promotional materials, it might be quicker to replace it with one of them. |
From the ones in the play store screenshots, I guess "this American life" would fit best because it is more internal than the others. What do you think? |
Closes #404.
I will need some help completing this one.
I also thought it would be nice to take the opportunity for two related improvements (help wanted):