Skip to content

Conversation

tugbakara
Copy link

@tugbakara tugbakara commented Oct 21, 2022

To limit the detection of april tags into ros side I have added if statement taking the distance from ros (pose.pose.pose.position.z) and limit this distance related to tag type.
EDIT: I will provide param distance values related to apriltag dimensions in launch file.
TODO
distance-size rates
parameter addition - I
parameter addition - II
parameter addition - III

Copy link
Collaborator

@wxmerkt wxmerkt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We cannot merge this as it's a hard-coded parameter which is unlikely to be useful for the majority of users.

@tugbakara
Copy link
Author

We cannot merge this as it's a hard-coded parameter which is unlikely to be useful for the majority of users.

Yeap, I know that's why I will add parameter in launch file that user can make change.

@tugbakara
Copy link
Author

tugbakara commented Jun 23, 2024

sorry for the latency, Now the pr is ready.

@tugbakara tugbakara closed this Jun 23, 2024
@tugbakara tugbakara reopened this Jun 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants