Skip to content

Conversation

jack-slip
Copy link
Contributor

Can be useful for hashing tag bundles for consumers of a /tag_detection stream

Copy link
Collaborator

@wxmerkt wxmerkt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the PR. While I agree with the usefulness of having the names, we don't want to change messages of released packages (it would make rosbags etc. incompatible) - sorry

@jack-slip
Copy link
Contributor Author

Thank you for the PR. While I agree with the usefulness of having the names, we don't want to change messages of released packages (it would make rosbags etc. incompatible) - sorry

Understood. Would you be in favor of the default behavior being the current message structure for backwards compatibility, but have an optional param that can enable publishing of a new NamedAprilTagDetection(Array) type? Or something along those lines

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants