-
-
Notifications
You must be signed in to change notification settings - Fork 672
Support Deno With Loader #1207
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Add |
Should we have a module build process and switch the loader to Typescript? |
Some parts of the loader are a bit suboptimal to describe in TS, since it also does some dynamic magic here or there. In such cases I typically prefer to write it in JS right away, since porting to TS only adds complexity. Should be possible to provide it in ES module form quite easily, though. Just expecting a bit of a hassle to make that a nice hybrid module to publish to npm. Last time I checked node and mjs/non-mjs still used to be unnecessarily painful, but I guess you guys are more up to date there than I am :) |
We could use esm or use some simple and lightweight module which transform esm to cjs as build stage |
Bootstrapping a module here is a trivial task using the deno/std/node library. I believe there's a problem with the loader itself. Will have to look further. |
Closing this issue as part of 2020 vacuum as ESM support is now being tracked in #1306, a more general issue also covering this one. |
This is a very easy change. All we need to do is switch to es module exports.
See: https://github.com/crabmusket/deno_assemblyscript_example
Any thoughts?
The text was updated successfully, but these errors were encountered: