Skip to content

Update Binaryen for 2020 #1034

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Jan 1, 2020
Merged

Update Binaryen for 2020 #1034

merged 8 commits into from
Jan 1, 2020

Conversation

dcodeIO
Copy link
Member

@dcodeIO dcodeIO commented Jan 1, 2020

In celebration of the new year, this updates our Binaryen bindings to include fireworks.

  • Update bindings
  • Attempt to avoid versioning issues on the web
  • Integrate new reference types features (ref.null, ref.is_null, ref.func)

@dcodeIO
Copy link
Member Author

dcodeIO commented Jan 1, 2020

Last commit also adds a little SDK to use on the web, primarily targeting WebAssembly Studio, that glues asc to the specific Binaryen version it requires. If that works as expected, we can get rid of conflicts by using the SDK in studio's setup code.

@dcodeIO
Copy link
Member Author

dcodeIO commented Jan 1, 2020

What's left is ref.func, which we don't have a good story for yet. For instance, we can't do

var some: anyref = someFunc;

yet due to someFunc being represented by a function table index, while ref.func wants a static function index (respectively function name in the Binaryen API). Perhaps we can compile that differently, will take a look.

@dcodeIO
Copy link
Member Author

dcodeIO commented Jan 1, 2020

Ok, that turned out to be easier than expected :)

@dcodeIO dcodeIO marked this pull request as ready for review January 1, 2020 21:47
@dcodeIO dcodeIO merged commit dc07392 into master Jan 1, 2020
@dcodeIO dcodeIO deleted the binaryen2020 branch March 15, 2020 13:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants