Improve typed array sort #1040
Closed
Improve typed array sort #1040
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@dcodeIO It's actually workaround which also has less retains. But I guess problem with RC in similar situations not solved in general case |
|
Seems the related issue is #1039. Should probably fix the underlying problem, but wondering how that happens. |
…into fix-typed-array-sort
MaxGraey
commented
Jan 3, 2020
Comment on lines
-3385
to
-3396
| call $~lib/rt/pure/__retain | ||
| local.tee $1 | ||
| call $~lib/typedarray/Int64Array#get:length | ||
| local.tee $2 | ||
| i32.const 1 | ||
| i32.le_s | ||
| if | ||
| local.get $1 | ||
| call $~lib/rt/pure/__release | ||
| br $~lib/typedarray/SORT<~lib/typedarray/Float64Array,f64>|inlined.0 | ||
| end | ||
| local.get $1 |
MaxGraey
commented
Jan 3, 2020
| i32.load | ||
| local.set $6 | ||
| i32.const 2 | ||
| global.set $~lib/argc |
There was a problem hiding this comment.
@dcodeIO could we avoid this somehow?
There was a problem hiding this comment.
That's there because we can't tell whether we are calling a trampoline under the hood, so if we do, it needs to know how many args to fill. For instance:
function a(a: i32): i32 { return a; }
function b(a: i32, b?: i32 = 1) { return a + b; }
var c = someCond ? a : b;
c(2); // must indicate one arg is present so b|trampoline inserts b=1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #1039