Fix missing reference conversion case #1058
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Last commit implements special code for the reference case and also inserts a runtime check when casting from a nullable to a non-nullable type that the compiler cannot prove to be correct. However, by moving this there's also the case of upcasting that must be handled with a runtime check I guess. |
|
It also relate to #234 |
MaxGraey
reviewed
Jan 15, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We were missing a diagnostic for conversions involving references, where an explicit conversion would pick up a pointer and convert it without complaining. This adds the diagnostic, but doesn't yet attempt to make string to number conversions more convenient (than
parseInt).Related: nearprotocol/near-runtime-ts#108