Skip to content

Fixed missing exports in asinit #1325

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 11, 2020
Merged

Fixed missing exports in asinit #1325

merged 2 commits into from
Jun 11, 2020

Conversation

ncave
Copy link
Contributor

@ncave ncave commented Jun 10, 2020 •
edited
Loading

  • Fixed default package template's exports.

@dcodeIO
Copy link
Member

dcodeIO commented Jun 11, 2020 •
edited
Loading

Oh, right, the loader's instantiate result changed lately and this hasn't been updated. LGTM in general, but a simpler fix with less changes might be simply

"module.exports = loader.instantiateSync(fs.readFileSync(__dirname + \"/build/optimized.wasm\"), { /* imports */ }).exports"

unless you think that it adds clarity as proposed here?

@ncave
Copy link
Contributor Author

ncave commented Jun 11, 2020 •
edited
Loading

@dcodeIO Yes, the separate line is just for clarity.

@dcodeIO dcodeIO merged commit 4808e4d into AssemblyScript:master Jun 11, 2020
@dcodeIO
Copy link
Member

dcodeIO commented Jun 11, 2020

Alright, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ncave @dcodeIO