Skip to content

ModuleExport#identifier never used, so just use Element directly #244

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

andy-hanson
Copy link
Contributor

Noticed that this class was only used for a single member; so it makes more sense to just use that member directly and remove the class. (And it looks like that would have been the only place where Program exposed AST nodes.)

@dcodeIO
Copy link
Member

dcodeIO commented Sep 9, 2018

I believe the reasoning here is that the identifier for an export can differ from the identifier of the element, for example in:

import { A as B } from "some/file";
export { B };

which makes the export use identifier B instead of the element's declared identifier A. To me it seems that .identifier should actually be read somewhere, which might be a bug. If not that, it might be there for diagnostics that just don't exist yet. Hmm...

@dcodeIO
Copy link
Member

dcodeIO commented Feb 20, 2019

Superseded by #489, which updates the representation of module exports as well.

@dcodeIO dcodeIO closed this Feb 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants