Add an InternalName type for clarity #246
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I see how this might be helpful, but at some point all these names should be replaced with proper symbols anyway (unfortunately this is unlikely to help with clarity) to reduce the amount of string comparisons necessary, i.e. performance. Hence, not sure. |
|
While I have your attention, could you explain more about internal names? While working on #249 I noticed that exports are looked up in a big global map by using a name qualified by the Source path, but why not just have a separate map per Source? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds
type InternalName = string;to be used to mark names that are not simple names.Note that this leads to a funny type annotation
externalName: InternalName;-- maybe that should be renamed tointernalNameOfExport.