Improve arrow function parsing #256
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andy-hanson
force-pushed
the
arrow-function-parsing
branch
from
24d6822 to
2cff7e0
Compare
dcodeIO
reviewed
Sep 10, 2018
src/parser.ts
Outdated
| @@ -1420,6 +1420,11 @@ export class Parser extends DiagnosticEmitter { | |||
| return Node.createFunctionExpression(declaration); | |||
| } | |||
|
|
|||
| private parseArrowFunctionBody(tn: Tokenizer): Statement | null { | |||
| // TODO: should parse an expression unless the next token is `{`. | |||
There was a problem hiding this comment.
tn.peek() can check the next token, would that help?
dcodeIO
reviewed
Sep 10, 2018
src/compiler.ts
Outdated
| @@ -5445,7 +5444,9 @@ export class Compiler extends DiagnosticEmitter { | |||
| } | |||
| } | |||
| } else { | |||
| body.push(this.compileStatement(bodyStatement)); | |||
| body.push(bodyStatement instanceof Expression | |||
There was a problem hiding this comment.
This should probably be bodyStatement.kind != NodeKind.BLOCK, as instanceof isn't supported (yet, without a GC).
dcodeIO
added a commit
that referenced
this pull request
Oct 4, 2018
Quite similar to #256 and also uses its test, but also fixes the serializer and doesn't try to parse an untyped 'x => x'.
|
The commit above does something very similar with a somewhat reduced refactoring footprint. Also fixes related serializer issues but doesn't tackle |
|
Closing in favor of referenced commit. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes parsing for #255. Does not fix the issue since a conditional expression is still unsupported in the resolver.
Previously at
(a ? b : c)(), we would assume thata ? b : cwere the parameters of an arrow function because every token involved was a valid token to appear in a signature -- but that wasn't strict enough. Now we will verify that?is always followed by:,,, or), none of which are legal in expressions.Also correctly parses
x => xnow, though it still won't compile.